Form elements #208
Merged
Form elements #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrimesdev
force-pushed
the
feature/form-elements
branch
2 times, most recently
from
8cfbfb2 to
d5b3b47
Compare
Add all of the GOV.UK form elements with individual examples, macros and documentation. Ready for overlaying the NHS styles to create our own form elements.
Fix the scss linting issues for the form elements and also add code comments in the correct format.
Add links to all the form elements example variants and GitHub issue for discussion.
Remove the temporary form element variables for border sizing and element sizing.
Add the nunjucks macro arguments table, to documentat what arguments of the form element macros take.
chrimesdev
force-pushed
the
feature/form-elements
branch
from
a4938cd to
c19649c
Compare
Add styles for a transactional header with a service name and update the nunjucks macro to pass through parameters for the service name and href. Create an example page.
chrimesdev
force-pushed
the
feature/form-elements
branch
from
c19649c to
6446084
Compare
Started to add new NHS form styles to the form elements. Created a test page 'forms.njk' to replicate the teams designs.
Added test page for ndop. Changed nhsuk-focusable mixin to use box-shadow instead of outline. This has fixed the focus issue on the button.
Updated the error link colour on hover. Changed the service name font-weight to regular. Also removed redundant link on components page.
Reduced form group margin-bottom.
Added a class of `nhsuk-form-group--wrapper ` to give the spacing we need at the bottom of forms.
Allow extra form group classes on all form components, which were originally just on radios and and checkboxes. alphagov/govuk-frontend#1059
Increased button padding on desktop.
Added new nhs svg logos (replaced exisiting and added a white version). Refactored footer to fit new design. Updated footer macro template to allow the logo to be hidden. Updated the html background colour to match the footer. Updated readme with the new footer templates. Created an example page of a footer with no logo.
Instead of using the arrow-shape mixin to generate an icon, use the NHS chevron SVG icon.
Added transactional and service variations of the header. Changed button font-size to be 19px on both desktop and mobile.
Removed footer logo from test pages.
Back link - amended code to include a surrounding div in order so it could be displayed as a block element. Having the `<a>` set as `display: block;` caused issues with the hover styling. Button - changed the font-size to scale on mobile. Footer - amended the visited link colour to not turn purple. Updated the logo sizes with the new mixin `nhsuk-logo-size`. Header - we now have 7 variations of the header. Each one is documented in the readme and has an example in the docs. This includes variants for transactional services and also for services that are not transactional and need the search (eg: Service manual).
chrimesdev
force-pushed
the
feature/form-elements
branch
from
71b8812 to
c036dad
Compare
chrimesdev
force-pushed
the
feature/form-elements
branch
from
c036dad to
7b0a408
Compare
Minor formatting to the files Nunjucks updates Add extra example with logo only Readme updates
…nd into feature/form-elements
Add homeHref Nunjucks parameter Correct close div nesting issue. Will be refactored to make code easier to read.
chrimesdev
force-pushed
the
feature/form-elements
branch
4 times, most recently
from
13ac90a to
bad562b
Compare
chrimesdev
force-pushed
the
feature/form-elements
branch
from
bad562b to
e575ba4
Compare
chrimesdev
force-pushed
the
feature/form-elements
branch
from
e575ba4 to
7f7c1ed
Compare
davidhunter08
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add all of the GOV.UK form elements with individual examples, macros
and documentation. Ready for overlaying the NHS styles to create our
own form elements.
Component checklist