Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add href config to the header template #193

Closed
mikemonteith opened this issue Nov 13, 2018 · 2 comments
Closed

Add href config to the header template #193

mikemonteith opened this issue Nov 13, 2018 · 2 comments

Comments

@mikemonteith
Copy link
Contributor

Add a config option so that the NHS logo in the header can link to somewhere other than /.
Example use case: https://nhsuk.github.io/nhsuk-frontend/ should link to /nhsuk-frontend/ instead of /.

Q: Is this ever going to be an issue for anyone else?
@chrimesdev
Copy link
Member

chrimesdev commented Nov 13, 2018 •
edited
Loading

I can see this being needed in transactional headers, people may want to link back to the start page of the transaction rather than the NHS Homepage. Or even services (such as the service manual) may want to link to their homepage rather than the NHS.

@chrimesdev
Copy link
Member

chrimesdev commented Nov 20, 2018 •
edited
Loading

This work has been picked up as part of the form elements (transactional header) in PR #208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikemonteith @chrimesdev