Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase memory available for AP xml parser #2455

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

galitskiy
Copy link
Contributor

Proposed changes

Increase memory available for xml parser in order to avoid potential issues with big policies.
https://docs.nginx.com/nginx-app-protect/admin-guide/install/#:~:text=file.%20The%20number-,471859200,-should%20be%20enough

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #2455 (465dfbe) into main (143b9b2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2455   +/-   ##
=======================================
  Coverage   53.49%   53.49%           
=======================================
  Files          49       49           
  Lines       14314    14314           
=======================================
  Hits         7657     7657           
  Misses       6414     6414           
  Partials      243      243           
Impacted Files Coverage Δ
internal/nginx/manager.go 0.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lucacome lucacome added the enhancement Pull requests for new features/feature enhancements label Apr 5, 2022
@lucacome lucacome merged commit 4854f49 into nginx:main Apr 5, 2022
@lucacome lucacome changed the title increase memory available for xml parser Increase memory available for AP xml parser Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants