Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app protect reconnect period directive #2360

Merged
merged 6 commits into from
Mar 15, 2022

Conversation

galitskiy
Copy link
Contributor

Proposed changes

Add app_protect_reconnect_period_seconds directive, which determines the period of time between reconnect retries of the app-protect module to the web application firewall (WAF) engine.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@galitskiy galitskiy changed the title Add app_protect_reconnect_period_seconds directive Add app protect reconnect period directive Jan 18, 2022
@nginx-bot nginx-bot force-pushed the ap-reconnect-period branch 2 times, most recently from 459332b to e9bb59c Compare January 18, 2022 23:46
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #2360 (0f8ce5b) into master (8791d41) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2360      +/-   ##
==========================================
+ Coverage   53.65%   53.68%   +0.03%     
==========================================
  Files          48       48              
  Lines       14220    14230      +10     
==========================================
+ Hits         7630     7640      +10     
  Misses       6349     6349              
  Partials      241      241              
Impacted Files Coverage Δ
internal/configs/config_params.go 76.74% <ø> (ø)
internal/configs/version1/config.go 0.00% <ø> (ø)
internal/configs/configmaps.go 18.22% <100.00%> (+1.44%) ⬆️
internal/configs/parsing_helpers.go 69.23% <100.00%> (+0.31%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@nginx-bot nginx-bot force-pushed the ap-reconnect-period branch 9 times, most recently from 6ff41e1 to aac29e4 Compare January 25, 2022 22:18
Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments, mostly about clarifying the allowed values and adding them to the docs.

internal/configs/configmaps.go Outdated Show resolved Hide resolved
internal/configs/configmaps.go Show resolved Hide resolved
@galitskiy galitskiy closed this Feb 24, 2022
@galitskiy galitskiy reopened this Feb 24, 2022
@galitskiy galitskiy force-pushed the ap-reconnect-period branch 2 times, most recently from a1546ea to 9c4ef69 Compare February 24, 2022 21:57
@lucacome lucacome requested review from a team and pleshakov February 25, 2022 01:05
Copy link
Contributor

@jputrino jputrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending application of suggestion

@lucacome lucacome requested a review from ciarams87 March 1, 2022 03:01
@lucacome lucacome requested a review from tomasohaodha March 1, 2022 03:03
Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good, but I just noticed that the pipeline is not triggered. I'm going to block the merge until we sort that out.

@lucacome lucacome added the enhancement Pull requests for new features/feature enhancements label Mar 11, 2022
@lucacome lucacome merged commit 5c043d0 into nginx:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants