-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add app protect reconnect period directive #2360
Conversation
459332b
to
e9bb59c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2360 +/- ##
==========================================
+ Coverage 53.65% 53.68% +0.03%
==========================================
Files 48 48
Lines 14220 14230 +10
==========================================
+ Hits 7630 7640 +10
Misses 6349 6349
Partials 241 241
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
6ff41e1
to
aac29e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments, mostly about clarifying the allowed values and adding them to the docs.
3334fb1
to
c4d49db
Compare
a1546ea
to
9c4ef69
Compare
9c4ef69
to
b64bb5a
Compare
docs/content/configuration/global-configuration/configmap-resource.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending application of suggestion
…urce.md Co-authored-by: Jodie Putrino <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good, but I just noticed that the pipeline is not triggered. I'm going to block the merge until we sort that out.
Proposed changes
Add app_protect_reconnect_period_seconds directive, which determines the period of time between reconnect retries of the app-protect module to the web application firewall (WAF) engine.
Checklist
Before creating a PR, run through this checklist and mark each as complete.