-
Notifications
You must be signed in to change notification settings - Fork 837
Add new module called rundbcan and subcommands(database, cazymeannotation, easycgc, easysubstrate) #8216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I will say in future can you please make individual PRs for subtools, it will be easier and faster for you to get them reviewed one at a time than all together. |
I'm really sorry for the inconvenience. I'll split the tools next time. |
tuple val(meta), path(input_raw_data) | ||
tuple val(meta), path(input_gff) | ||
tuple val(meta), val (gff_type) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, I think the gff_type could be with the gff itself, and you can't have meta multiple times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could each of the tools (except the database generation) create the files directly in the work directory, instead of inside a folder? You would then want to rename them with the prefix after creation, because it looks like it makes the files with identical filenames, but it'll mean that the output folders wouldn't be nested in the same way.
I'm sorry, but the run_dbcan tool won't give the output files individually; the entire output folder contains all outputs. This is an original design from a previous developer, and I kept the same idea from them. |
PR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda