-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add index format to samtools view #7481
base: master
Are you sure you want to change the base?
Conversation
4d38e7a
to
bb3ec89
Compare
fb0476d
to
2c988a4
Compare
61958a0
to
de3c4c1
Compare
de3c4c1
to
161a736
Compare
I believe all remaining lint and pytest-workflow failures are not due to updating this module, but other module updates that I can't adress in this PR. |
It is trying to lint top-level tools again, rather than the subtool :|
|
Can we exclude the pytests |
f085fe4
to
524b9e0
Compare
558be5d
to
d13abb1
Compare
d13abb1
to
16f4dc2
Compare
Making a separate PR: #7482 |
Adds an
index_format
that specifies index generation explicitly (as suggested by @SPPearce), while still allowing forext.args
to contain--write-index
(which generates the index with the default samtools index format for the filetype).Would supersede #4326.
Also:
PR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda