Make erroring wave builds fail CI

[edmundmiller]

So we can know when the arm builds are failing. Reporting hook to come later.

[mashehu]

why not 4?

[edmundmiller]

Why set a limit at all? Idk, I think it was to not soak up a ton of runners.

[ewels]

Looks like this logic is the wrong way around, meant that only PRs coming from branches on the nf-core repo were being run:

modules/.github/workflows/wave.yml

Line 25 in 326bde8

if: github.event.pull_request.head.repo.full_name == github.repository

@edmundmiller I'm not sure that we want to fail builds yet - are we confident enough that it won't block new modules?

[edmundmiller]

Looks like this logic is the wrong way around, meant that only PRs coming from branches on the nf-core repo were being run:

No that's the right way around because it fails if you try to make a PR from anywhere but the nf-core modules repo. So it should skip.

Ideally, the bumps will come only from the renovate commits. Users will still have to make the initial containers.

@edmundmiller I'm not sure that we want to fail builds yet - are we confident enough that it won't block new modules?

@ewels This PR was because you asked for it 🤣 I think it's fine; it's not required, so it won't block the PR.

[mashehu]

People get confused about failing tests, even if the tests are not required. Better to skip it/succeed with warning.

[edmundmiller]

People get confused about failing tests, even if the tests are not required. Better to skip it/succeed with warning.

Sounds good! Closing this then, and we'll link to it if anyone asks and can revisit it later.