Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run prettier on taxonkit/lineage/meta.yml #7366

Merged

Conversation

erikrikarddaniel
Copy link
Member

@erikrikarddaniel erikrikarddaniel commented Jan 25, 2025

PR checklist

This should fix a catch 22 we're having with #metatdenovo.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@erikrikarddaniel
Copy link
Member Author

Thanks for such a quick review on a Saturday morning! :-)

@erikrikarddaniel
Copy link
Member Author

BTW, @mahesh-panchal , I'm assuming the failed tests are due to technical problems at GitHub or something with our tools -- are you allowed to bypass that? I could only put it in the queue and it will be waiting for tests that won't trigger again I guess.

@sateeshperi sateeshperi disabled auto-merge January 25, 2025 08:26
@sateeshperi sateeshperi merged commit 90c5156 into nf-core:master Jan 25, 2025
18 of 21 checks passed
@erikrikarddaniel
Copy link
Member Author

Much obliged, @sateeshperi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants