Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added nf-test for bedtools/intersect #6658

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Added nf-test for bedtools/intersect #6658

merged 3 commits into from
Sep 18, 2024

Conversation

LeonHafner
Copy link
Contributor

@LeonHafner LeonHafner commented Sep 17, 2024 •
edited
Loading

Converted pytest to nf-test for bedtools/intersect

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.

@LeonHafner LeonHafner marked this pull request as ready for review September 17, 2024 19:18
SPPearce
SPPearce reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the test paths to match the current style?

@LeonHafner LeonHafner requested a review from SPPearce September 18, 2024 14:20
@SPPearce SPPearce enabled auto-merge September 18, 2024 14:46
@SPPearce
Copy link
Contributor

Thanks!

@SPPearce SPPearce added this pull request to the merge queue Sep 18, 2024
Merged via the queue into nf-core:master with commit 749d72f Sep 18, 2024
12 checks passed
herpov pushed a commit to herpov/modules that referenced this pull request Oct 2, 2024
@LeonHafner @SPPearce
Added nf-test for bedtools/intersect (nf-core#6658)
f6bbf85 
* migrate bedtools/intersect to nftest

* changed test file paths

---------

Co-authored-by: Simon Pearce <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPPearce SPPearce SPPearce approved these changes

@edmundmiller edmundmiller Awaiting requested review from edmundmiller edmundmiller is a code owner

@sruthipsuresh sruthipsuresh Awaiting requested review from sruthipsuresh

@drpatelh drpatelh Awaiting requested review from drpatelh

@sidorov-si sidorov-si Awaiting requested review from sidorov-si

Assignees
No one assigned
Labels
nf-test Ready for Review
Projects
nf-test Migration
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeonHafner @SPPearce