Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made gtf input optional for star/genomegenerate #4627

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Dec 18, 2023

PR checklist

Closes #XXX

  • Made gtf input optional for star/genomegenerate. This should not affect existing module users.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@GallVp GallVp added this pull request to the merge queue Dec 19, 2023
Merged via the queue into nf-core:master with commit d87a6e2 Dec 19, 2023
11 checks passed
@GallVp GallVp deleted the star/genomegenerate branch December 19, 2023 19:45
lrauschning pushed a commit to lrauschning/modules that referenced this pull request Dec 21, 2023
lrauschning pushed a commit to lrauschning/modules that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants