Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use remote repos with include statement #3

Closed
drpatelh opened this issue Jul 28, 2019 · 2 comments
Closed

Use remote repos with include statement #3

drpatelh opened this issue Jul 28, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Comments

@drpatelh
Copy link
Member

Need to test and possibly work out a way to use a remote git repo with the include statement
e.g.

modules_base = "https://raw.githubusercontent.com/nf-core/modules/${params.module_version}"
include "${modules_base}" params(params)
@drpatelh drpatelh added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Jul 28, 2019
@drpatelh
Copy link
Member Author

This will no longer be an issue with the proposed implementation in #8 because modules will be pre-installed into the pipeline repo. Is this ok to close @ewels ?

@ewels
Copy link
Member

ewels commented Jul 11, 2020

Yup 👍 Although I still think that this would be very elegant, Paolo's recommendation was "never do this" and I agree it does cause a set of problems of its own. As you say, #8 is an alternative approach which we will use instead.

@ewels ewels closed this as completed Jul 11, 2020
jasmezz added a commit that referenced this issue May 2, 2022
* Update main.nf

* Update meta.yml

* Update test.yml
CarsonJM added a commit to CarsonJM/modules that referenced this issue Sep 10, 2024
…lows (nf-core#3)

* Started adding nf-microbe functions, modules. subworkflows, and workflows

* Removed objects for later additions, and started fixing bowtie2 subworkflow

* Added FASTQ_BOWTIE2_FASTQ snapshot and updated CI

* Updated subworkflow tests

* Fix CI attempt #1

* Fixed function tests and linting

* Fixed failing nf-tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants