Limit duration format according to spec #20
Conversation
nexus/api.go
Outdated
| @@ -333,3 +335,32 @@ func validateLinkType(value string) error { | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| var durationRegexp = regexp.MustCompile("^(\\d+)(ms|s|m|h)$") | |||
There was a problem hiding this comment.
I think floats should be supported. Spec says "Format of this parameter is number + unit" and I took "number" to mean float as did the Java PR.
There was a problem hiding this comment.
Yes , the server does generate floats
There was a problem hiding this comment.
Also h is not supported by the spec?
Format of this header value is number + unit, where unit can be
msfor milliseconds,sfor seconds, andmfor
minutes.
There was a problem hiding this comment.
Hmmm... if the server generates floats we'll need to support parsing it for compatibility but I'd stop generating floats on the server ASAP and use ints instead.
Definitely can get rid of h, thanks for pointing that out, I should've checked, I was looking at @cretz's comment in the Java PR ("s", "m", or "h").
There was a problem hiding this comment.
Is there a reason we didn't do ISO 8601 durations?
There was a problem hiding this comment.
Just felt like overkill and we wanted a format that can be easily typed in a curl command.
bergundy
force-pushed
the
limited-duration-format
branch
from
34e6136 to
66e899e
Compare
bergundy
force-pushed
the
limited-duration-format
branch
from
f619c04 to
2439122
Compare
We used to accept anything
time.ParseDurationwould parse which is too broad and violates the spec.Also ensured that we use a custom
formatDurationimplementation to ensure compatibility.