Fix lint and add another test case

nexus-rpc · Sep 13, 2024 · 2439122 · 2439122
1 parent 66e899e
commit 2439122
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/nexus/api.go b/nexus/api.go
@@ -336,7 +336,7 @@ func validateLinkType(value string) error {
 	return nil
 }
 
-var durationRegexp = regexp.MustCompile("^(\\d+(?:\\.\\d+)?)(ms|s|m)$")
+var durationRegexp = regexp.MustCompile(`^(\d+(?:\.\d+)?)(ms|s|m)$`)
 
 func parseDuration(value string) (time.Duration, error) {
 	m := durationRegexp.FindStringSubmatch(value)

diff --git a/nexus/api_test.go b/nexus/api_test.go
@@ -511,9 +511,12 @@ func TestDecodeLink(t *testing.T) {
 }
 
 func TestParseDuration(t *testing.T) {
-	d, err := parseDuration("invalid")
+	_, err := parseDuration("invalid")
 	require.ErrorContains(t, err, "invalid duration:")
-	d, err = parseDuration("10ms")
+	d, err := parseDuration("10ms")
+	require.NoError(t, err)
+	require.Equal(t, 10*time.Millisecond, d)
+	d, err = parseDuration("10.1ms")
 	require.NoError(t, err)
 	require.Equal(t, 10*time.Millisecond, d)
 	d, err = parseDuration("1s")