Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update use of OCA.Viewer api to the nextcloud 22 version #1776

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

juliusknorr
Copy link
Member

#1775 for master

Looks like the accessor to state was removed from the Viewer api
and replaced with separate getters.

So we need to replace OCA.Viewer.state.file with OCA.Viewer.file.

Fixes #1676

Looks like the [accessor to state] was removed from the Viewer api
and replaced with [separate getters].

So we need to replace `OCA.Viewer.state.file` with `OCA.Viewer.file`.

Fixes #1676

[accessor to state]: (nextcloud/viewer@dbfa6bc#diff-c29528ea58a2d0307765d4357b88c9a469c148ccca2d82b653dbb97290ab6ab1L52-L63)
[separate getters]: (nextcloud/viewer@dbfa6bc#diff-c29528ea58a2d0307765d4357b88c9a469c148ccca2d82b653dbb97290ab6ab1R79-R81)

Signed-off-by: Azul <[email protected]>
@juliusknorr juliusknorr added this to the Nextcloud 23 milestone Jul 19, 2021
@juliusknorr juliusknorr requested review from azul and mejo- July 19, 2021 06:19
Copy link
Contributor

@azul azul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thanks for the rebase.

@juliusknorr juliusknorr merged commit d5cc85e into master Jul 19, 2021
@juliusknorr juliusknorr deleted the bugfix/1676 branch July 19, 2021 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue when opening files that contain links
2 participants