New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue when opening files that contain links #1676

Closed

juliusknorr opened this issue Jun 22, 2021 · 1 comment · Fixed by #1775 or #1776

Labels

bug

Member

juliusknorr commented Jun 22, 2021

juliusknorr added the bug label

Contributor

azul commented Jul 18, 2021

Looks like the accessor to state was removed from the Viewer api:
nextcloud/viewer@dbfa6bc#diff-c29528ea58a2d0307765d4357b88c9a469c148ccca2d82b653dbb97290ab6ab1L52-L63
and replaced with separate getters:
nextcloud/viewer@dbfa6bc#diff-c29528ea58a2d0307765d4357b88c9a469c148ccca2d82b653dbb97290ab6ab1R79-R81

So we need to replace OCA.Viewer.state.file with OCA.Viewer.file.

azul added a commit that referenced this issue


          Update use of OCA.Viewer api to the nextcloud 22 version

47f0bfe

Looks like the [accessor to state] was removed from the Viewer api
and replaced with [separate getters].

So we need to replace `OCA.Viewer.state.file` with `OCA.Viewer.file`.

Fixes #1676

[accessor to state]: (nextcloud/viewer@dbfa6bc#diff-c29528ea58a2d0307765d4357b88c9a469c148ccca2d82b653dbb97290ab6ab1L52-L63)
[separate getters]: (nextcloud/viewer@dbfa6bc#diff-c29528ea58a2d0307765d4357b88c9a469c148ccca2d82b653dbb97290ab6ab1R79-R81)

Signed-off-by: Azul <[email protected]>

azul mentioned this issue

Azul/fix links 1676 #1775

Merged

juliusknorr pushed a commit that referenced this issue


          Update use of OCA.Viewer api to the nextcloud 22 version

cbd6c91

Looks like the [accessor to state] was removed from the Viewer api
and replaced with [separate getters].

So we need to replace `OCA.Viewer.state.file` with `OCA.Viewer.file`.

Fixes #1676

[accessor to state]: (nextcloud/viewer@dbfa6bc#diff-c29528ea58a2d0307765d4357b88c9a469c148ccca2d82b653dbb97290ab6ab1L52-L63)
[separate getters]: (nextcloud/viewer@dbfa6bc#diff-c29528ea58a2d0307765d4357b88c9a469c148ccca2d82b653dbb97290ab6ab1R79-R81)

Signed-off-by: Azul <[email protected]>

juliusknorr mentioned this issue

Update use of OCA.Viewer api to the nextcloud 22 version #1776

Merged

juliusknorr closed this as completed in #1776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment