Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Shipped apps should include the Nextcloud version in the cache buster #48650

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 10, 2024

Summary

  1. The hash should also include the Nextcloud version if the app is shipped as every new Nextcloud update = new app version
  2. Cache the hash to prevent re-generation if the path is the same (e.g. the same app uses a lot of scripts / styles).

Checklist

@susnux susnux added bug 3. to review Waiting for reviews php Pull requests that update Php code feature: templates labels Oct 10, 2024
@susnux susnux added this to the Nextcloud 31 milestone Oct 10, 2024
@susnux susnux force-pushed the fix/shipped-app-version branch from 346f5d4 to b999a3b Compare October 10, 2024 16:58
…uster

Co-authored-by: Ferdinand Thiessen <[email protected]>
Co-authored-by: Kate <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/shipped-app-version branch from 1658ab9 to 980ab1f Compare October 14, 2024 14:04
@susnux
Copy link
Contributor Author

susnux commented Oct 14, 2024

/backport to stable30

@susnux susnux enabled auto-merge October 14, 2024 14:04
@susnux susnux merged commit 262ed0f into master Oct 14, 2024
177 checks passed
@susnux susnux deleted the fix/shipped-app-version branch October 14, 2024 15:22
Copy link

backportbot bot commented Oct 14, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/48650/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 980ab1f5

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/48650/stable30

Error: Failed to push branch backport/48650/stable30: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request bug feature: templates php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Force reload required after upgrade 29 -> 30
3 participants