Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Force reload required after upgrade 29 -> 30 #46976

Closed
4 of 8 tasks
Tracked by #5249
SystemKeeper opened this issue Aug 2, 2024 · 5 comments · Fixed by #48650
Closed
4 of 8 tasks
Tracked by #5249

[Bug]: Force reload required after upgrade 29 -> 30 #46976

SystemKeeper opened this issue Aug 2, 2024 · 5 comments · Fixed by #48650
Assignees
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 30-feedback bug feature: caching Related to our caching system: scssCacher, jsCombiner... feature: files feature: install and update

Comments

@SystemKeeper
Copy link
Contributor

⚠️ This issue respects the following points: ⚠️

Bug description

After upgrading from 29.0.4 to 30.0.0 Beta 3 a force reload was required on the users end (multiple apps were affected, like talk, forms,…). Seems that our cachebuster has an issue somewhere?

Steps to reproduce

  1. Upgrade from 29 to 30

Expected behavior

No force reload required

Installation method

None

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@SystemKeeper SystemKeeper added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Aug 2, 2024
@juliusknorr
Copy link
Member

Not entirely sure if that is the cause but could contribute to it: nextcloud-libraries/nextcloud-vite-config#267

@sorbaugh
Copy link
Contributor

sorbaugh commented Oct 1, 2024

Can you please look @susnux 🙏

@sorbaugh
Copy link
Contributor

sorbaugh commented Oct 9, 2024

Proposed way forward by @nickvergessen if I understood correctly: Check if it's a shipped app and additionaly use the Nextcloud Version to create a new hash.

@susnux
Copy link
Contributor

susnux commented Oct 9, 2024

So some background:

There was a bug in nextcloud-vite config, this now fixed. All apps that updated to v1.4.2 or later should work correctly.
But there is still a problem for shipped apps like the viewer if their version number does not change -> same cache buster.

@nickvergessen
Copy link
Member

But there is still a problem for shipped apps like the viewer if their version number does not change -> same cache buster.

That's where:

Check if it's a shipped app and additionaly use the Nextcloud Version to create a new hash.

would come in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 30-feedback bug feature: caching Related to our caching system: scssCacher, jsCombiner... feature: files feature: install and update
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants