Fix comparisons in apps #4790
Merged
Fix comparisons in apps #4790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
nickvergessen
commented
May 10, 2017
| @@ -147,7 +147,7 @@ public function put($data) { | |||
| // compare expected and actual size | |||
| if (isset($_SERVER['CONTENT_LENGTH']) && $_SERVER['REQUEST_METHOD'] === 'PUT') { | |||
| $expected = $_SERVER['CONTENT_LENGTH']; | |||
| if ($count != $expected) { | |||
| if ($count !== $expected) { | |||
There was a problem hiding this comment.
int + strings are compared, need to fix
nickvergessen
commented
May 10, 2017
| @@ -410,7 +410,7 @@ private function createFileChunked($data) { | |||
| if (isset ($_SERVER['REQUEST_METHOD']) && $_SERVER['REQUEST_METHOD'] === 'PUT') { | |||
| if (isset($_SERVER['CONTENT_LENGTH'])) { | |||
| $expected = $_SERVER['CONTENT_LENGTH']; | |||
| if ($bytesWritten != $expected) { | |||
| if ($bytesWritten !== $expected) { | |||
There was a problem hiding this comment.
int + strings are compared, need to fix
|
I would say this is not the best point in time to do stuff like that. 🙈 |
|
Yeah I just wanted to have one check passed, so we can run the general tests (info.xml, language and database), but maybe it's easier to add an option to only run those... |
MorrisJobke
force-pushed
the
fix-comparisons-in-apps
branch
from
ef202f3 to
145e3f5
Compare
Codecov Report
@@ Coverage Diff @@
## master #4790 +/- ##
============================================
- Coverage 57.06% 54.14% -2.92%
- Complexity 21017 22345 +1328
============================================
Files 1245 1380 +135
Lines 71040 85551 +14511
Branches 0 1329 +1329
============================================
+ Hits 40537 46323 +5786
- Misses 30503 39228 +8725
|
|
Rebased on current master. @nickvergessen Could you please fix the comments you have? |
nickvergessen
added
3. to review
MorrisJobke
approved these changes
Jun 21, 2017
MorrisJobke
added
2. developing
nickvergessen
commented
Jun 22, 2017
apps/files_versions/lib/Storage.php
Outdated
| @@ -161,7 +161,7 @@ private static function getVersionsSize($user) { | |||
| * store a new version of a file. | |||
| */ | |||
| public static function store($filename) { | |||
| if(\OCP\Config::getSystemValue('files_versions', Storage::DEFAULTENABLED)=='true') { | |||
| if(\OCP\Config::getSystemValue('files_versions', Storage::DEFAULTENABLED)) { | |||
There was a problem hiding this comment.
Comparing bool to string worked before, however this config is not documented anywhere.
@schiessle any idea what other values are and why it exists?
nickvergessen
force-pushed
the
fix-comparisons-in-apps
branch
from
de1ba6e to
622d80d
Compare
nickvergessen
added
3. to review
|
Rebased and fixed |
MorrisJobke
approved these changes
Jul 27, 2017
|
Needs a rebase... |
Signed-off-by: Joas Schilling <[email protected]>
Let me try. |
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
MorrisJobke
force-pushed
the
fix-comparisons-in-apps
branch
from
622d80d to
a209342
Compare
|
Rebased. |
rullzer
approved these changes
Aug 1, 2017
MorrisJobke
added
4. to release
|
Phan fail is unrelated? |
Correct - this is fixed in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via #4767