Fix comparisions in the trashbin app

Signed-off-by: Joas Schilling <[email protected]>
nextcloud · May 10, 2017 · ef202f3 · ef202f3
1 parent e15a698
commit ef202f3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/apps/files_trashbin/lib/Storage.php b/apps/files_trashbin/lib/Storage.php
@@ -206,7 +206,7 @@ protected function shouldMoveToTrash($path){
 			return false;
 		}
 
-		if ($this->userManager->userExists($parts[1]) && $parts[2] == 'files') {
+		if ($this->userManager->userExists($parts[1]) && $parts[2] === 'files') {
 			return true;
 		}
 

diff --git a/apps/files_trashbin/lib/Trashbin.php b/apps/files_trashbin/lib/Trashbin.php
@@ -93,7 +93,7 @@ public static function getUidAndFilename($filename) {
 			return [null, null];
 		}
 		Filesystem::initMountPoints($uid);
-		if ($uid != User::getUser()) {
+		if ($uid !== User::getUser()) {
 			$info = Filesystem::getFileInfo($filename);
 			$ownerView = new View('/' . $uid . '/files');
 			try {

diff --git a/apps/testing/locking/provisioning.php b/apps/testing/locking/provisioning.php
@@ -212,9 +212,9 @@ public function releaseAll(array $parameters) {
 			if (strpos($lock, 'locking_') === 0) {
 				$path = substr($lock, strlen('locking_'));
 
-				if ($type === ILockingProvider::LOCK_EXCLUSIVE && $this->config->getAppValue('testing', $lock) == ILockingProvider::LOCK_EXCLUSIVE) {
+				if ($type === ILockingProvider::LOCK_EXCLUSIVE && (int) $this->config->getAppValue('testing', $lock) === ILockingProvider::LOCK_EXCLUSIVE) {
 					$lockingProvider->releaseLock($path, $this->config->getAppValue('testing', $lock));
-				} else if ($type === ILockingProvider::LOCK_SHARED && $this->config->getAppValue('testing', $lock) == ILockingProvider::LOCK_SHARED) {
+				} else if ($type === ILockingProvider::LOCK_SHARED && (int) $this->config->getAppValue('testing', $lock) === ILockingProvider::LOCK_SHARED) {
 					$lockingProvider->releaseLock($path, $this->config->getAppValue('testing', $lock));
 				} else {
 					$lockingProvider->releaseLock($path, $this->config->getAppValue('testing', $lock));