-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): Correctly handle open file URL query #47015
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <[email protected]>
… open by default Signed-off-by: Ferdinand Thiessen <[email protected]>
This was referenced Aug 3, 2024
skjnldsv
approved these changes
Aug 3, 2024
juliusknorr
approved these changes
Aug 3, 2024
/compile |
Signed-off-by: nextcloud-command <[email protected]>
/backport to stable29 |
/backport to stable28 |
2 tasks
2 tasks
1 task
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There were 3 issues:
openfile
is set on the query not as a paramopenfile
notopenFile
openfile
query on the redirect.Sadly we can not really test this as the viewer is not included.
Screen recording
Bildschirmaufnahme_20240803_141453.webm
Checklist