fix: Do not skip handleOpenFile calls on initial load #47014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
fix/openfile
branch
from
7b78fa9 to
c9e5a36
Compare
susnux
requested changes
Aug 3, 2024
| @@ -247,10 +247,6 @@ export default defineComponent({ | |||
| * @param fileId File to open | |||
| */ | |||
| handleOpenFile(fileId: number|null) { | |||
| if (!this.openFile) { | |||
There was a problem hiding this comment.
This line is pretty valid, as the viewer should / must only open when openfile is set.
So there is an other bug: #47015
One of the reasons I think every force-enabled app should be part of the server repo or at least be a submodul. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
We noticed this in text cypress last week:
Good server commit: 57ed738
Bad server commit: 97ea957
From the diff could be related to #45708
It would be really great to have tests for this in server, but as viewer is a separate app we would need to have it enabled for the cypress tests in server to achieve that.