Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide default avatar in secure drop #4609

Closed
wants to merge 1 commit into from

Conversation

MorrisJobke
Copy link
Member

I'm a bit unsure if we should do it - @nextcloud/designers please give feedback.

Before:

bildschirmfoto 2017-04-30 um 19 25 05

After:

bildschirmfoto 2017-04-30 um 19 24 28
bildschirmfoto 2017-04-30 um 19 24 53

* fixes #1896

Signed-off-by: Morris Jobke <[email protected]>
@MorrisJobke MorrisJobke added 3. to review Waiting for reviews design Design, UI, UX, etc. feature: sharing papercut Annoying recurring issue with possibly simple fix. labels Apr 30, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone Apr 30, 2017
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @blizzz and @rullzer to be potential reviewers.

@MariusBluem
Copy link
Member

MariusBluem commented May 1, 2017

Looks a bit empty now 🤔 ... I'd say no 👎

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, as the default avatar really adds no value here.

Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks quite horrible to be honest 🙈

Copy link
Member

@MariusBluem MariusBluem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment above: #4609 (comment)

@MorrisJobke MorrisJobke closed this May 1, 2017
@MorrisJobke MorrisJobke deleted the hide-default-avatar-secure-drop branch May 1, 2017 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. feature: sharing papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files drop: don’t show avatar placeholder if no avatar is present
5 participants