Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files drop: don’t show avatar placeholder if no avatar is present #1896

Closed
jancborchardt opened this issue Oct 24, 2016 · 4 comments
Closed

Files drop: don’t show avatar placeholder if no avatar is present #1896

jancborchardt opened this issue Oct 24, 2016 · 4 comments
Labels
design Design, UI, UX, etc. enhancement feature: sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@jancborchardt
Copy link
Member

For the file upload without file listing, we show the avatar nice and big. And that is cool.

However – when the sharer has no avatar set, it will show the giant circled first letter. This is rather useless and just takes attention away from the upload button.

If no avatar is set, the element should simply not be shown.

cc @nextcloud/javascript
@jancborchardt jancborchardt added enhancement design Design, UI, UX, etc. 1. to develop Accepted and waiting to be taken care of feature: sharing labels Oct 24, 2016
@jancborchardt jancborchardt added this to the Nextcloud 11.0 milestone Oct 24, 2016
@MorrisJobke MorrisJobke added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Nov 24, 2016
@MorrisJobke
Copy link
Member

@stephanruttloff Maybe also something for you 😉

MorrisJobke added a commit that referenced this issue Apr 30, 2017
@MorrisJobke
Hide default avatar in secure drop
80e07ec 
* fixes #1896

Signed-off-by: Morris Jobke <[email protected]>
@MorrisJobke MorrisJobke removed the 1. to develop Accepted and waiting to be taken care of label Apr 30, 2017
@MorrisJobke MorrisJobke mentioned this issue Apr 30, 2017
Closed
@MorrisJobke
Copy link
Member

Fix is in #4609

@MorrisJobke
Copy link
Member

There are many votes against it in #4609 - I will close this one here as well, because I also doesn't like it. 👎

@MorrisJobke MorrisJobke removed this from the Nextcloud 12.0 milestone May 1, 2017
@jancborchardt
Copy link
Member Author

Yeah, seems to be better even if it’s only a placeholder. Good on testing it out so we know it’s better like it already is! :)

@Jessi1983 Jessi1983 mentioned this issue Mar 10, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design Design, UI, UX, etc. enhancement feature: sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide default avatar in secure drop nextcloud/server
2 participants
@MorrisJobke @jancborchardt