Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autocomplete attrs to input fields #38147

Merged
merged 1 commit into from
May 11, 2023
Merged

Add autocomplete attrs to input fields #38147

merged 1 commit into from
May 11, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented May 9, 2023 •
edited
Loading

Summary

No visual changes.
Add autocomplete attrs to input fields. Additional info: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete and https://www.w3.org/TR/WCAG21/#input-purposes section "7. Input Purposes for User Interface Components"

Checklist

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this May 9, 2023
@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label May 9, 2023
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as draft May 9, 2023 12:53
@JuliaKirschenheuter JuliaKirschenheuter added 2. developing Work in progress 3. to review Waiting for reviews and removed 3. to review Waiting for reviews 2. developing Work in progress labels May 9, 2023
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review May 9, 2023 13:04
artonge
artonge approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Pytal
Pytal approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from removals requested below

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36945-input_fields_do_not_convey_the_purpose_of_each_field_through_a_language branch from 540cf8d to 8eb289b Compare May 10, 2023 09:41
@JuliaKirschenheuter
Add autocomplete attrs to input fields
b54afad 
Signed-off-by: julia.kirschenheuter <[email protected]>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36945-input_fields_do_not_convey_the_purpose_of_each_field_through_a_language branch from 8eb289b to b54afad Compare May 11, 2023 08:16
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 11, 2023
@Pytal Pytal merged commit d5588f3 into master May 11, 2023
@Pytal Pytal deleted the fix/36945-input_fields_do_not_convey_the_purpose_of_each_field_through_a_language branch May 11, 2023 16:34
@AndyScherzinger AndyScherzinger added this to the Nextcloud 27 milestone May 11, 2023
@blizzz blizzz mentioned this pull request May 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@susnux susnux Awaiting requested review from susnux

@nfebe nfebe Awaiting requested review from nfebe

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 27
4 participants
@JuliaKirschenheuter @artonge @Pytal @AndyScherzinger