Skip to content

Commit

Permalink
Add autocomplete attrs to input fields
Browse files Browse the repository at this point in the history
Signed-off-by: julia.kirschenheuter <[email protected]>
  • Loading branch information
JuliaKirschenheuter committed May 10, 2023
1 parent f63c2db commit 8eb289b
Show file tree
Hide file tree
Showing 10 changed files with 15 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
<template>
<AccountPropertySection v-bind.sync="displayName"
:placeholder="t('settings', 'Your full name')"
autocomplete="username"
:is-editable="displayNameChangeSupported"
:on-validate="onValidate"
:on-save="onSave" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@
<input :id="inputId"
ref="email"
type="email"
autocomplete="email"
:placeholder="inputPlaceholder"
:value="email"
:aria-describedby="helperText ? `${inputId}-helper-text` : ''"
autocapitalize="none"
autocomplete="on"
autocorrect="off"
@input="onEmailChange">

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

<template>
<AccountPropertySection v-bind.sync="location"
autocomplete="address-level1"
:placeholder="t('settings', 'Your location')" />
</template>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

<template>
<AccountPropertySection v-bind.sync="organisation"
autocomplete="organization"
:placeholder="t('settings', 'Your organisation')" />
</template>

Expand Down
1 change: 1 addition & 0 deletions apps/settings/src/components/PersonalInfo/PhoneSection.vue
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
<template>
<AccountPropertySection v-bind.sync="phone"
:placeholder="t('settings', 'Your phone number')"
autocomplete="tel"
type="tel"
:on-validate="onValidate" />
</template>
Expand Down
1 change: 1 addition & 0 deletions apps/settings/src/components/PersonalInfo/RoleSection.vue
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

<template>
<AccountPropertySection v-bind.sync="role"
autocomplete="organization-title"
:placeholder="t('settings', 'Your role')" />
</template>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
<template>
<AccountPropertySection v-bind.sync="website"
:placeholder="t('settings', 'Your website')"
autocomplete="url"
type="url"
:on-validate="onValidate" />
</template>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@
:value="value"
:aria-describedby="helperText ? `${name}-helper-text` : ''"
autocapitalize="none"
autocomplete="on"
autocorrect="off"
:autocomplete="autocomplete"
@input="onPropertyChange">

<div class="property__actions-container">
Expand Down Expand Up @@ -132,6 +132,10 @@ export default {
type: Function,
default: null,
},
autocomplete: {
type: String,
default: null,
},
},

data() {
Expand Down
4 changes: 2 additions & 2 deletions dist/settings-vue-settings-personal-info.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/settings-vue-settings-personal-info.js.map

Large diffs are not rendered by default.

0 comments on commit 8eb289b

Please sign in to comment.