Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dav): Use an icon with correct color for calendar user settings section #37526

Merged
merged 1 commit into from
Apr 5, 2023
Merged

fix(dav): Use an icon with correct color for calendar user settings section #37526

merged 1 commit into from
Apr 5, 2023

Conversation

tcitworld
Copy link
Member

@tcitworld tcitworld commented Mar 31, 2023 •
edited
Loading

Before After
image image

Follow-up to #34746

Checklist

@tcitworld tcitworld added this to the Nextcloud 27 milestone Mar 31, 2023
@tcitworld tcitworld requested review from ChristophWurst, juliusknorr and a team March 31, 2023 18:23
@tcitworld tcitworld self-assigned this Mar 31, 2023
@tcitworld tcitworld requested review from ArtificialOwl, icewind1991 and come-nc and removed request for a team March 31, 2023 18:23
@tcitworld
Copy link
Member Author

/backport to stable26

szaimen
szaimen approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@tcitworld tcitworld force-pushed the use-correct-icon-for-calendar-user-settings-section branch from b415ec4 to d87e55c Compare April 4, 2023 08:07
@tcitworld tcitworld requested a review from juliusknorr April 4, 2023 08:08
@ChristophWurst ChristophWurst added the 4. to release Ready to be released and/or waiting for tests to finish label Apr 4, 2023
@juliusknorr
Copy link
Member

Failure unrelated

@juliusknorr juliusknorr merged commit 2dc96b3 into master Apr 5, 2023
@juliusknorr juliusknorr deleted the use-correct-icon-for-calendar-user-settings-section branch April 5, 2023 14:11
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@szaimen szaimen szaimen approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc was automatically assigned from nextcloud/server-backend

Assignees

@tcitworld tcitworld

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: dav feature: settings
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
4 participants
@tcitworld @juliusknorr @ChristophWurst @szaimen