Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Calendar settings section #34746

Merged
merged 1 commit into from
Nov 13, 2022
Merged

Conversation

tcitworld
Copy link
Member

@tcitworld tcitworld commented Oct 22, 2022

In replacement of the removed Groupware settings section in #34626

One of my own apps used the groupware section. The calendar app itself might make use of it too. #34626 (comment)

To merge after #34626

@tcitworld tcitworld added 3. to review Waiting for reviews feature: settings feature: caldav Related to CalDAV internals labels Oct 22, 2022
@tcitworld tcitworld added this to the Nextcloud 26 milestone Oct 22, 2022
@tcitworld tcitworld requested review from ChristophWurst and a team October 22, 2022 18:24
@tcitworld tcitworld requested a review from CarlSchwan as a code owner October 22, 2022 18:24
@tcitworld tcitworld force-pushed the add-calendar-settings-section branch 3 times, most recently from 5adbd63 to e2655d4 Compare October 22, 2022 18:36
@tcitworld tcitworld changed the title Add Calendar settings section and adapt CalDAVSettings to use it Add Calendar settings section Oct 22, 2022
In replacement of the removed Groupware settings section in #34626

Signed-off-by: Thomas Citharel <[email protected]>
@tcitworld tcitworld force-pushed the add-calendar-settings-section branch from e2655d4 to 8b13f6d Compare October 24, 2022 08:41
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Oct 24, 2022
@ChristophWurst
Copy link
Member

We can list this section in nextcloud/documentation#9249 as alternative to Availability

@tcitworld
Copy link
Member Author

Should it be backported as well?

@ChristophWurst
Copy link
Member

I am not sure. Let's see how the #34626 backports go. I still consider this a breaking change as it will cause trouble for any existing app that rendered onto the groupware page.

@juliusknorr juliusknorr merged commit 7e229aa into master Nov 13, 2022
@juliusknorr juliusknorr deleted the add-calendar-settings-section branch November 13, 2022 16:06
@DaphneMuller
Copy link

hello @tcitworld ,
Thank you for your work on this pull request! This ticket seems to have the tag 'missing documentation', is there any chance you could clarify what documentation is missing? Is this for admins or for app developers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: caldav Related to CalDAV internals feature: settings pending documentation This pull request needs an associated documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants