Normalize key before passing it to memcached #32925
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would obsolete #28481 so we could also remove the hashing there if we're confident that it doesn't affect redis ? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
normalize-key
branch
from
6819ef9 to
bc3aa70
Compare
blizzz
reviewed
Jun 17, 2022
| if (version_compare(PHP_VERSION, '8.1.0') >= 0) { | ||
| return hash('xxh128', $key); // Very fast and provide very good collisions protection | ||
| } else { | ||
| return hash('md5', $key); |
There was a problem hiding this comment.
too many collisions. maybe only if indeed whitespace is included or the key is exceeds the length limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.