Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash cache key #28481

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Hash cache key #28481

merged 1 commit into from
Aug 18, 2021

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Aug 17, 2021

Hash cache key to ensure that only valid characters are used 🔑

@Pytal Pytal added bug 3. to review Waiting for reviews labels Aug 17, 2021
@Pytal Pytal added this to the Nextcloud 23 milestone Aug 17, 2021
@Pytal Pytal self-assigned this Aug 17, 2021
@Pytal
Copy link
Member Author

Pytal commented Aug 17, 2021

/backport to stable22

@Pytal
Copy link
Member Author

Pytal commented Aug 17, 2021

/backport to stable21

@Pytal
Copy link
Member Author

Pytal commented Aug 17, 2021

/backport to stable20

@Pytal
Hash cache key
60ecc43 
Signed-off-by: Christopher Ng <[email protected]>
@skjnldsv

This comment has been minimized.

Sign in to view
skjnldsv
skjnldsv approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code make sense

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 18, 2021
szaimen
szaimen requested changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many tests are failing?

@juliusknorr
Copy link
Member

Looks like a temporary issue with composer but lets restart

@juliusknorr
Copy link
Member

Failure unrelated

@juliusknorr juliusknorr requested a review from szaimen August 18, 2021 13:18
@juliusknorr juliusknorr merged commit 95987d9 into master Aug 18, 2021
@juliusknorr juliusknorr deleted the fix/hash-key branch August 18, 2021 13:18
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 18, 2021
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 18, 2021
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Aug 18, 2021 •
edited by Pytal
Loading

The backport to stable20 failed. Please do this backport manually.

Not applicable due to cache not being implemented in stable20

@PVince81 PVince81 mentioned this pull request Jun 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@artonge artonge Awaiting requested review from artonge

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
5 participants
@Pytal @skjnldsv @juliusknorr @blizzz @szaimen