Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow dynamic autoloading for classes added during upgrade #5295

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jun 7, 2023

Fixes #5191

nextcloud/server#6853 + authoritative class loaders for apps distributed via the app store is problematic. Problem introduced with #4912.

What I have tested

  • composer/autoload.php + authoritative class loader optimization: 💥 (main)
  • composer/autoload.php + apcu class loader optimization: 😎
  • composer/autoload.php + basic class map optimization: 😎 (here)
  • no composer/autoload.php: 😎

To do

  • Test that fails to load dynamically created classes
  • Fix the autoloader config

How to test

  1. Run composer i
  2. composer run test tests/php/integration/Composer

@ChristophWurst ChristophWurst added the 2. developing Work in progress label Jun 7, 2023
@ChristophWurst ChristophWurst self-assigned this Jun 7, 2023
@ChristophWurst ChristophWurst marked this pull request as draft June 7, 2023 18:39
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -8.51 ⚠️

Comparison is base (9ae057a) 22.38% compared to head (a75fad5) 13.88%.

❗ Current head a75fad5 differs from pull request most recent head c88cb60. Consider uploading reports for the commit c88cb60 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5295      +/-   ##
============================================
- Coverage     22.38%   13.88%   -8.51%     
============================================
  Files           238      201      -37     
  Lines         11617     9644    -1973     
  Branches       2253     2253              
============================================
- Hits           2601     1339    -1262     
+ Misses         9016     8305     -711     
Flag Coverage Δ
javascript 13.88% <0.00%> (ø)
php ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/Editor/Invitees/InviteesList.vue 0.00% <0.00%> (ø)

... and 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChristophWurst
Copy link
Member Author

/backport to stable3.2

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Jun 7, 2023
@GretaD GretaD force-pushed the fix/dynamic-autoloading branch from a75fad5 to c88cb60 Compare June 9, 2023 10:25
@GretaD GretaD enabled auto-merge June 9, 2023 10:25
@GretaD
Copy link
Contributor

GretaD commented Jun 9, 2023

/backport to stable4.4

@GretaD GretaD merged commit 13b6560 into main Jun 9, 2023
@GretaD GretaD deleted the fix/dynamic-autoloading branch June 9, 2023 10:29
@backportbot-nextcloud
Copy link

The backport to stable3.2 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable3.2
git pull origin stable3.2

# Create the new backport branch
git checkout -b fix/foo-stable3.2

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable3.2

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@ChristophWurst
Copy link
Member Author

/backport to stable4.3

@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request A backport was requested for this pull request label Jun 12, 2023
R0Wi added a commit to R0Wi-DEV/workflow_ocr that referenced this pull request Sep 10, 2023
R0Wi added a commit to R0Wi-DEV/workflow_ocr that referenced this pull request Sep 10, 2023
R0Wi added a commit to R0Wi-DEV/workflow_ocr that referenced this pull request Sep 10, 2023
R0Wi added a commit to R0Wi-DEV/workflow_ocr that referenced this pull request Sep 10, 2023
R0Wi added a commit to R0Wi-DEV/workflow_ocr that referenced this pull request Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.4.0-alpha.2: Migration step 'OCA\Calendar\Migration\Version4004Date20230414163505' is unknown
3 participants