-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow dynamic autoloading for classes added during upgrade #5295
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5295 +/- ##
============================================
- Coverage 22.38% 13.88% -8.51%
============================================
Files 238 201 -37
Lines 11617 9644 -1973
Branches 2253 2253
============================================
- Hits 2601 1339 -1262
+ Misses 9016 8305 -711
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
/backport to stable3.2 |
Signed-off-by: Christoph Wurst <[email protected]>
a75fad5
to
c88cb60
Compare
/backport to stable4.4 |
The backport to stable3.2 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable3.2
git pull origin stable3.2
# Create the new backport branch
git checkout -b fix/foo-stable3.2
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable3.2 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
/backport to stable4.3 |
Fixes #5191
nextcloud/server#6853 + authoritative class loaders for apps distributed via the app store is problematic. Problem introduced with #4912.
What I have tested
composer/autoload.php
+ authoritative class loader optimization: 💥 (main)composer/autoload.php
+ apcu class loader optimization: 😎composer/autoload.php
+ basic class map optimization: 😎 (here)composer/autoload.php
: 😎To do
How to test
composer i
composer run test tests/php/integration/Composer