Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(autoloader): Use Composer's authoritative classmap #4912

Merged

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jan 20, 2023

Theoretically this could speed things up but I'm not able to proof that with blackfire nor simple timings.

Before optimizing all four Groupware apps

Bildschirmfoto vom 2023-01-20 13-21-55

After optimizing all four Groupware apps

Bildschirmfoto vom 2023-01-20 13-22-06

@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Jan 20, 2023
@ChristophWurst ChristophWurst self-assigned this Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 22.25% // Head: 22.25% // No change to project coverage 👍

Coverage data is based on head (0eb41dc) compared to base (0bf6b13).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4912   +/-   ##
=========================================
  Coverage     22.25%   22.25%           
  Complexity      334      334           
=========================================
  Files           227      227           
  Lines         10788    10788           
  Branches       2044     2044           
=========================================
  Hits           2401     2401           
  Misses         8387     8387           
Flag Coverage Δ
javascript 14.23% <ø> (ø)
php 64.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Development

Successfully merging this pull request may close these issues.

2 participants