Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(723): Title Bar Storybook Enhancement #889

Merged
merged 17 commits into from
May 18, 2023
Merged

docs(723): Title Bar Storybook Enhancement #889

merged 17 commits into from
May 18, 2023

Conversation

jannuk59
Copy link
Contributor

closes #725

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@jannuk59 jannuk59 added docs Improvements or additions to documentation ready for design review Please assist in getting this reviewed labels May 12, 2023
@pp-serviceaccount
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/725-titlebar-storybook
Storybook: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/725-titlebar-storybook/storybook

@jannuk59 jannuk59 marked this pull request as ready for review May 17, 2023 12:48
@jannuk59 jannuk59 added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels May 17, 2023
Vanals
Vanals previously approved these changes May 18, 2023
View reviewed changes
JohnTParsons
JohnTParsons reviewed May 18, 2023
View reviewed changes
src/title-bar/__tests__/title-bar.stories.tsx Outdated
export const StoryTitleBar = () => <TitleBar>{STRING}</TitleBar>;
StoryTitleBar.storyName = 'Default';

export const StoryTitleBarLink = () => (
<>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fragment can be removed as only one child

src/title-bar/__tests__/title-bar.stories.tsx Outdated
</TitleBar>
</StorybookCase>
</StorybookPage>
</>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fragment can be removed as only one child

JohnTParsons
JohnTParsons approved these changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@JohnTParsons JohnTParsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jannuk59 jannuk59 merged commit 2cb8a37 into main May 18, 2023
@jannuk59 jannuk59 deleted the docs/725-titlebar-storybook branch May 18, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vanals Vanals Vanals approved these changes

@JohnTParsons JohnTParsons JohnTParsons approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Title bar component scenarios - Storybook
4 participants
@jannuk59 @pp-serviceaccount @JohnTParsons @Vanals