-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Title bar component scenarios - Storybook #725
Comments
GeriReid
added
story
a user facing change
and removed
task
A non user facing change
labels
Mar 27, 2023
8 tasks
thanks @jannuk59.
Rest looks good, thanks :) |
@nathanparris removed extra gap at the top of the title bar when we dont have heading. Please have a review at it http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/725-titlebar-storybook/storybook/?path=/docs/components-title-bar--story-title-bar |
@jannuk59 Looks good to me |
Thanks @nathanparris. Moving to peer review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Updates to the Title bar component scenarios- Storybook
Tasks/Steps
Notes (main differences to what we have currently live versus the designs)
Acceptance/Testing Criteria
Given I am in Storybook
When I view the Title bar component pages
Then the pages will be updated as per the designs
And the pages will be within 1024x768 for Applitools snapshots.
Business Benefit/Value
Consistent Title bar component examples for consumers, aligning to the NK branding.
The text was updated successfully, but these errors were encountered: