Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Title bar component scenarios - Storybook #725

Closed
jps opened this issue Mar 22, 2023 · 5 comments · Fixed by #889
Closed

Update Title bar component scenarios - Storybook #725

jps opened this issue Mar 22, 2023 · 5 comments · Fixed by #889
Assignees
Labels
story a user facing change

Comments

@jps
Copy link
Contributor

jps commented Mar 22, 2023

Description

Updates to the Title bar component scenarios- Storybook

Tasks/Steps

  • Using the designs update the storybook pages for the Title bar component.
  • The designs include what should be on each page, and the title, description, and link to the documentation page on the site for the component.
  • Note the name of the pages also should be updated to match what we have in the designs.

Notes (main differences to what we have currently live versus the designs)

  • Remove title-bar, added variations to other stories
  • Default - new story
  • Variations - new story
  • Overrides - new story

Acceptance/Testing Criteria

Given I am in Storybook
When I view the Title bar component pages
Then the pages will be updated as per the designs
And the pages will be within 1024x768 for Applitools snapshots.

Business Benefit/Value

Consistent Title bar component examples for consumers, aligning to the NK branding.

@jps jps added this to NewsKit Mar 22, 2023
@jps jps converted this from a draft issue Mar 22, 2023
@jps jps added this to the Storybook Enhancements milestone Mar 22, 2023
@jps jps added the task A non user facing change label Mar 22, 2023
@GeriReid GeriReid added story a user facing change and removed task A non user facing change labels Mar 27, 2023
@jps jps removed the status in NewsKit Mar 28, 2023
@jps jps moved this to Backlog in NewsKit Apr 14, 2023
@jps jps moved this from Backlog to Analysis in NewsKit Apr 24, 2023
@LukeFinch LukeFinch moved this from Analysis to Ready to do in NewsKit May 4, 2023
@jannuk59 jannuk59 self-assigned this May 8, 2023
@jannuk59 jannuk59 moved this from Ready to do to In progress in NewsKit May 8, 2023
@jannuk59 jannuk59 moved this from In progress to Design review in NewsKit May 12, 2023
@GeriReid
Copy link
Contributor

thanks @jannuk59.

  • On the examples without a heading could you please remove the extra padding above the title, so it sits centrally:
image
  • Logical Props - lowercase p in the heading please to read Logical props

Rest looks good, thanks :)

@jannuk59
Copy link
Contributor

@nathanparris removed extra gap at the top of the title bar when we dont have heading. Please have a review at it http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/725-titlebar-storybook/storybook/?path=/docs/components-title-bar--story-title-bar

@nathanparris
Copy link
Contributor

@jannuk59 Looks good to me

@jannuk59
Copy link
Contributor

Thanks @nathanparris. Moving to peer review

@jannuk59 jannuk59 moved this from Design review to Peer review in NewsKit May 17, 2023
@jannuk59 jannuk59 moved this from Peer review to Done in NewsKit May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story a user facing change
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants