Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(834): use circle CI test splitting for cypress #841

Merged
merged 8 commits into from
Apr 21, 2023

Conversation

jps
Copy link
Contributor

@jps jps commented Apr 20, 2023

#834

What

  1. Background - cypress-parallel is unstable at high levels of parallelization
  2. Have moved to using the inbuilt circle cli commands to split the tests, and removed cypress-parallel library
  3. Tests running at high levels of parallelism without error see both comps and docs for examples.
    The doc site tests run in ~3:40 vs ~6:30, component tests are about the same. A possible extension to this would be to split the components a11y tests as per the docs, this would result in a good speed up as splitting would be more effective.

@jps jps changed the title ci(834): try alternate approach ci(834): try alternate cypress splitting approach Apr 20, 2023
@jps jps marked this pull request as ready for review April 20, 2023 13:42
@jps jps added the ready for review Please assist in getting this reviewed label Apr 20, 2023
@jps jps changed the title ci(834): try alternate cypress splitting approach ci(834): use circle CI test splitting for cypress Apr 20, 2023
Copy link
Collaborator

@JohnTParsons JohnTParsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Should be more stable.

Hopefully this technique integrate well with future nx/rspack/cypress features.

@jps jps merged commit 3835cd0 into main Apr 21, 2023
@jps jps deleted the ci/834-try-alternate-splitting-approach branch April 21, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants