Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(834): cypress upgrade #835

Merged
merged 7 commits into from
May 2, 2023
Merged

chore(834): cypress upgrade #835

merged 7 commits into from
May 2, 2023

Conversation

JohnTParsons
Copy link
Collaborator

@JohnTParsons JohnTParsons commented Apr 18, 2023

closes #834

What

I tried prepending the cypress scripts in package.json with "ELECTRON_EXTRA_LAUNCH_ARGS=--disable-gpu" but made no difference.

So have just upgraded to latest Cypress version
and reduced the docs runners from 6 to 4 (same as comps, which has been stable).

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@pp-serviceaccount
Copy link
Collaborator

@JohnTParsons JohnTParsons added the ready for review Please assist in getting this reviewed label Apr 18, 2023
@JohnTParsons JohnTParsons marked this pull request as ready for review April 18, 2023 10:51
Vanals
Vanals previously approved these changes Apr 18, 2023
mutebg
mutebg previously approved these changes Apr 18, 2023
jps
jps previously approved these changes Apr 18, 2023
@JohnTParsons JohnTParsons removed the ready for review Please assist in getting this reviewed label Apr 19, 2023
@JohnTParsons
Copy link
Collaborator Author

I moved the simple change to reduce parallel runners from 6 to 4 into a different PR yesterday as the Cypress upgrade in this branch was getting test failures (though that might just have been an intermittent issue as has started working again today). Inclined to merge this PR after the next release to be on the safe side.

@jps
Copy link
Contributor

jps commented Apr 20, 2023

@JohnTParsons I had a go at the other approach mentioned in this blog post

I'm inclined to most forward with it as feel it's more flexible and stable that the cypress-parallel library

Here is what the results look like in circle

@JohnTParsons JohnTParsons changed the title ci(834): investigate cypress parallel failures chore(834): cypress upgrade Apr 21, 2023
@JohnTParsons JohnTParsons dismissed stale reviews from Vanals, mutebg, and jps via 3ad4f24 April 28, 2023 13:37
@JohnTParsons JohnTParsons force-pushed the ci/834-cypress-failures branch from 8d29694 to 3ad4f24 Compare April 28, 2023 13:37
@JohnTParsons JohnTParsons force-pushed the ci/834-cypress-failures branch from d2ddc0f to bf80431 Compare April 28, 2023 14:29
@JohnTParsons JohnTParsons added the ready for review Please assist in getting this reviewed label Apr 28, 2023
@JohnTParsons JohnTParsons merged commit 67160b3 into main May 2, 2023
@JohnTParsons JohnTParsons deleted the ci/834-cypress-failures branch May 2, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Cypress version
5 participants