-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(834): cypress upgrade #835
Conversation
You can preview these changes on: |
I moved the simple change to reduce parallel runners from 6 to 4 into a different PR yesterday as the Cypress upgrade in this branch was getting test failures (though that might just have been an intermittent issue as has started working again today). Inclined to merge this PR after the next release to be on the safe side. |
@JohnTParsons I had a go at the other approach mentioned in this blog post I'm inclined to most forward with it as feel it's more flexible and stable that the Here is what the results look like in circle |
8d29694
to
3ad4f24
Compare
d2ddc0f
to
bf80431
Compare
closes #834
What
I tried prepending the cypress scripts in package.json with "ELECTRON_EXTRA_LAUNCH_ARGS=--disable-gpu" but made no difference.
So have just upgraded to latest Cypress version
and reduced the docs runners from 6 to 4 (same as comps, which has been stable).
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: