Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2702): updated fieldset stories #738

Merged
merged 10 commits into from
Mar 31, 2023
Merged

docs(PPDSC-2702): updated fieldset stories #738

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4a6311a
docs(PPDSC-2702): updated stories
mstuartf Mar 22, 2023
9bbb02b
docs(PPDSC-2702): meta
mstuartf Mar 23, 2023
260f62c
docs(PPDSC-2702): a11y debugging
mstuartf Mar 24, 2023
874c6a8
docs(PPDSC-2702): design feedback
mstuartf Mar 24, 2023
653e56f
docs(PPDSC-2702): add row gaps
mstuartf Mar 24, 2023
87a68cd
docs(PPDSC-2702): correct colour tokens
mstuartf Mar 27, 2023
0bc39e2
docs(PPDSC-2702): use custom theme
mstuartf Mar 27, 2023
ae549eb
docs(PPDSC-2702): apply custom themes in a11y tests
mstuartf Mar 28, 2023
472b6ad
docs(PPDSC-2702): use sb components
mstuartf Mar 29, 2023
7c58b2a
Merge branch 'main' into docs/PPDSC-2702-fieldset-stories
mstuartf Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions e2e/tests.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@
/* eslint-env browser */

import React from 'react';
import {THEME_KEYS} from '../src/test/theme-select-object';

interface StoryType {
default: {
title: string;
decorators: Array<
(
Story: StoryType,
context: {globals: {backgrounds: {value: string}}},
context: {globals: {backgrounds: {value: string}}; name: string},
) => JSX.Element
>;
};
Expand Down Expand Up @@ -76,9 +77,13 @@ export default function showTestcase(theme: string | null) {
.map(Story => (
<>
{story.default.decorators[0](Story, {
name: Story.storyName,
globals: {
backgrounds: {
value: theme === 'dark' ? '#2E2E2E' : '#FFFFFF',
value:
theme === 'dark'
? THEME_KEYS.newskitDark
: THEME_KEYS.newskitLight,
},
},
})}
Expand Down
2 changes: 1 addition & 1 deletion src/assistive-text/assistive-text.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const ThemelessAssistiveText = React.forwardRef<
state={state}
role={state === 'invalid' ? 'alert' : undefined}
aria-live={state === 'invalid' ? 'polite' : undefined}
{...textBlockOverrides}
overrides={textBlockOverrides}
{...props}
>
{children}
Expand Down
Loading