Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2702): updated fieldset stories #738

Merged
merged 10 commits into from
Mar 31, 2023

Conversation

mstuartf
Copy link
Contributor

@mstuartf mstuartf commented Mar 22, 2023

PPDSC-2702

What

  1. Background - why this is needed
  2. What did you do
  • Story updates
  • Ensure custom storybook themes are used in e2e a11y tests
  1. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mstuartf mstuartf added docs Improvements or additions to documentation ready for design review Please assist in getting this reviewed labels Mar 22, 2023
@mstuartf mstuartf requested a review from a team as a code owner March 22, 2023 16:01
@pp-serviceaccount
Copy link
Collaborator

@mstuartf mstuartf changed the title docs(PPDSC-2702): updated stories docs(PPDSC-2702): updated fieldset stories Mar 27, 2023
JohnTParsons
JohnTParsons previously approved these changes Mar 28, 2023
@mutebg mutebg added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Mar 29, 2023
@mstuartf mstuartf merged commit 966e105 into main Mar 31, 2023
@mstuartf mstuartf deleted the docs/PPDSC-2702-fieldset-stories branch March 31, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Story) - Update Fieldset component scenarios - Storybook
4 participants