-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PPDSC-2859): use newskit-website theme from publisher #718
Conversation
You can preview these changes on: |
|
||
export const docsThemeLight = createTheme({ | ||
name: 'docs-theme-light', | ||
overrides: lightOverrides, | ||
baseTheme: newskitLightTheme, // TODO: Use newsKitTheme from Publisher eventually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you make ticket for this? in case we forget?
Sounds an extra good step for testing how user would implement it.
Even if, in this scenario I think we do not need to specify newskitLight as it is the default base theme inside the function, am I wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add it to the backlog 👍
Left a few comments but the rest looks good. If wasn't checked already could you also double check the SVG Previewer is behaving as expected? it uses all the doc site theme to preview the SVGs. It should correctly import and use the themes for displaying the SVG. |
good callout - I will double-check. |
site/components/__tests__/__snapshots__/enum-table.test.tsx.snap
Outdated
Show resolved
Hide resolved
site/components/__tests__/__snapshots__/enum-table.test.tsx.snap
Outdated
Show resolved
Hide resolved
LGTM |
PPDSC-2859
What
Background - why this is needed
Uses themes from the newskit-themes-publisher repo for the docs site.
What did you do
What does the reviewers should expect
Design changes have been manually checked and approved
Snapshot updates are mostly due to px changing to rem & hex codes coming in lower case
I've removed a test
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: