Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement newskit-site theme Publisher package in NewsKit repo #765

Closed
LukeFinch opened this issue Mar 24, 2023 · 0 comments · Fixed by #718
Closed

Implement newskit-site theme Publisher package in NewsKit repo #765

LukeFinch opened this issue Mar 24, 2023 · 0 comments · Fixed by #718
Assignees
Labels
task A non user facing change

Comments

@LukeFinch
Copy link
Contributor

Description

Now that we finally support all the NewsKit theme tokens with the nk-formatter, we want to try implementing the NewsKit site theme package in the Newskit repo.
We want to have a feel of how to implement our own product in Newskit.

Tasks/Steps

  • Install @newskit-themes/newskit-website
  • Import all the subthemes
  • Implement them in the docs-site
  • Remove any old tokens that have been replaced by the new package

Acceptance Criteria

  • Snapshots should match previous as this is a like-for-like change OR be approved changes by design
@LukeFinch LukeFinch added triage This issue will be reviewed by the team task A non user facing change and removed triage This issue will be reviewed by the team labels Mar 24, 2023
@LukeFinch LukeFinch moved this to In progress in NewsKit Mar 24, 2023
@LukeFinch LukeFinch moved this from In progress to Design review in NewsKit Apr 6, 2023
@LukeFinch LukeFinch linked a pull request Apr 14, 2023 that will close this issue
8 tasks
@jps jps assigned jps and unassigned LukeFinch Apr 17, 2023
@jps jps moved this from Design review to Peer review in NewsKit Apr 19, 2023
@jps jps closed this as completed in #718 Apr 19, 2023
@jps jps moved this from Peer review to Ready to deploy in NewsKit Apr 19, 2023
@jps jps moved this from Ready to deploy to Done in NewsKit Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task A non user facing change
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants