Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ppdsc 2611 revert #656

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Fix/ppdsc 2611 revert #656

merged 3 commits into from
Feb 21, 2023

Conversation

mstuartf
Copy link
Contributor

PPDSC-2611

What

  1. Background - why this is needed
  • Partial build is silently ignored when running percy tests on protected branches
  • This means that we have to run all baselines to update any baselines
  1. What did you do
  2. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mstuartf mstuartf added the fix This change fixes a bug label Feb 20, 2023
@mstuartf mstuartf requested a review from a team as a code owner February 20, 2023 16:43
@pp-serviceaccount
Copy link
Collaborator

@mstuartf mstuartf merged commit 9bdd5ab into main Feb 21, 2023
@mstuartf mstuartf deleted the fix/PPDSC-2611-revert branch February 21, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants