Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/ppdsc 2611 fix 1 #629

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Fix/ppdsc 2611 fix 1 #629

merged 3 commits into from
Feb 13, 2023

Conversation

mstuartf
Copy link
Contributor

PPDSC-XXXX

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mstuartf mstuartf requested a review from a team as a code owner February 13, 2023 09:51
@github-actions github-actions bot added the fix This change fixes a bug label Feb 13, 2023
@pp-serviceaccount
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2611-fix-1
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2611-fix-1/storybook

@mstuartf mstuartf merged commit 7ee4a68 into main Feb 13, 2023
@mstuartf mstuartf deleted the fix/PPDSC-2611-fix-1 branch February 13, 2023 11:35
mstuartf added a commit that referenced this pull request Feb 20, 2023
@mstuartf
fix(PPDSC-2611): Revert "Fix/ppdsc 2611 fix 1 (#629)"
b855a45 
This reverts commit 7ee4a68.
mstuartf added a commit that referenced this pull request Feb 21, 2023
@mstuartf
Fix/ppdsc 2611 revert (#656)
9bdd5ab 
* fix(PPDSC-2611): Revert "Fix/ppdsc 2611 fix 1 (#629)"

This reverts commit 7ee4a68.

* fix(PPDSC-2611): Revert "fix(PPDSC-2611): fix pipeline (#596)"

This reverts commit 1c001a9.

* fix(PPDSC-2611): Revert "chore(PPDSC-2611): fewer tests for baseline updates (#588)"

This reverts commit fd4d458.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTParsons JohnTParsons JohnTParsons approved these changes

@evgenitsn evgenitsn evgenitsn approved these changes

Assignees
No one assigned
Labels
fix This change fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mstuartf @pp-serviceaccount @evgenitsn @JohnTParsons