docs(PPDSC-2449): Add support to TextArea & TextField for users going over the set max length #465
Conversation
|
You can preview these changes on: |
jannuk59
requested review from
jps,
Xin00163,
pdimova,
baburay23,
Vanals,
evgenitsn and
Srinivasan-Ramasamy
as code owners
jannuk59
changed the title
| ); | ||
| }; | ||
|
|
||
| CharacterCountExceedMaxLength.storyName = 'MaxLength over limit'; |
There was a problem hiding this comment.
Just change the name of the story, the rest is pretty good
| CharacterCountExceedMaxLength.storyName = 'MaxLength over limit'; | |
| CharacterCountExceedMaxLength.storyName = 'Max Length over limit'; |
| return `You have ${diff} character${diff === 1 ? '' : 's'} remaining`; | ||
| return `You have ${Math.abs(diff)} character${ | ||
| diff === 1 || diff === -1 ? '' : 's' | ||
| } ${diff >= 0 ? 'remaining' : 'too many'}`; |
There was a problem hiding this comment.
I think you're unit test coverage check is failing because you have added branching logic here.
There are four scenarios that need tests:
- diff > 1
- diff === 1
- diff === -1
- diff < -1
You can check this by running the unit tests locally and looking at the coverage report generated.
There was a problem hiding this comment.
will do that @mstuartf
There was a problem hiding this comment.
@mstuartf diff > 1 and diff === 1 test scenarios already in place. So, I have done with the tests for diff === -1 and diff < -1. Checked the test coverages as well and its passing 100%. Please have a look at it and let me know yours thoughts if any.
PPDSC-2449
Added support to the users going over the MaxLength on set.
Users are not restricted from entering more information, allowing for editing down their input so it falls within the set limit. Users can input characters or copy and paste them even if they exceed the set character count.
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: