Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PPDSC-2244): create text-area component #364

Merged
merged 16 commits into from
Sep 14, 2022
Merged

feat(PPDSC-2244): create text-area component #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
de61b43
feat(PPDSC-2244): create text-area component
Sep 7, 2022
f2ac8d3
feat(PPDSC-2244): add resize prop
Sep 7, 2022
581b4a6
feat(PPDSC-2244): fix overrides
Sep 8, 2022
7da2f4f
feat(PPDSC-2244): add unit tests
Sep 8, 2022
ee47f5b
Merge branch 'main' into feat/PPDSC-2244-create-text-area
mutebg Sep 8, 2022
3e99f16
feat(PPDSC-2244): add text-area instrumantation and fix style preset
Sep 12, 2022
2c90558
feat(PPDSC-2244): update snapshots
Sep 12, 2022
a0d4347
feat(PPDSC-2244): fix coverage
Sep 12, 2022
52c899c
feat(PPDSC-2244): configure docs in storybook
Sep 12, 2022
c9c3351
feat(PPDSC-2244): update stories
Sep 12, 2022
e66fb94
Merge branch 'main' into feat/PPDSC-2244-create-text-area
mutebg Sep 12, 2022
93462e0
Merge branch 'main' into feat/PPDSC-2244-create-text-area
mutebg Sep 12, 2022
e2280d1
feat(PPDSC-2244): enhance storybook docs page
Sep 12, 2022
e08b534
feat(PPDSC-2244): clean up
Sep 12, 2022
a2f307a
feat(PPDSC-2244): update snapshots
Sep 12, 2022
7694c52
Merge branch 'main' into feat/PPDSC-2244-create-text-area
mutebg Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .storybook/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ const toPath = _path => path.join(process.cwd(), _path);

module.exports = {
stories: ['../src/**/*.stories.tsx'],
// todo: https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#deprecated---static-dir-cli-flag
addons: [
'@storybook/addon-links',
{
Expand All @@ -29,6 +28,15 @@ module.exports = {
},
},
},
{
name: '@storybook/addon-docs',
options: {
configureJSX: true,
babelOptions: {},
sourceLoaderOptions: null,
transcludeMarkdown: true,
},
},
],
// https://github.com/storybookjs/storybook/issues/13277
// Remove Emotion aliases once the issue above is resolved
Expand Down
11 changes: 8 additions & 3 deletions .storybook/preview-head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@
@font-face {
font-family: 'The Sun';
src: url('TheSun-HeavyNarrow.woff2') format('woff2'),
url('TheSun-HeavyNarrow.woff') format('woff');
url('TheSun-HeavyNarrow.woff') format('woff');
font-style: normal;
font-weight: 700;
font-stretch: condensed;
Expand All @@ -279,7 +279,7 @@
@font-face {
font-family: 'The Sun';
src: url('TheSun-Bold.woff2') format('woff2'),
url('TheSun-Bold.woff') format('woff');
url('TheSun-Bold.woff') format('woff');
font-style: normal;
font-weight: 700;
font-display: block;
Expand All @@ -288,7 +288,7 @@
@font-face {
font-family: 'The Sun';
src: url('TheSun-Medium.woff2') format('woff2'),
url('TheSun-Medium.woff') format('woff');
url('TheSun-Medium.woff') format('woff');
font-style: normal;
font-weight: 500;
font-display: block;
Expand Down Expand Up @@ -332,4 +332,9 @@
src: url(https://fonts.gstatic.com/s/montserrat/v21/JTUHjIg1_i6t8kCHKm4532VJOt5-QNFgpCtr6Hw9aXx-p7K4KLjztg.woff)
format('woff');
}

/* This is to override the size of Canvas in docs pages */
.docs-story .innerZoomElementWrapper > div > div > div {
position: relative;
}
</style>
28 changes: 23 additions & 5 deletions .storybook/preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,16 @@
import React from 'react';
import {INITIAL_VIEWPORTS} from '@storybook/addon-viewport';
import {withPerformance} from 'storybook-addon-performance';

import {NewsKitProvider, styled, getColorCssFromTheme} from '../src';
import {Stories, DocsContext} from '@storybook/addon-docs';
import {
NewsKitProvider,
styled,
getColorCssFromTheme,
newskitLightTheme,
ThemeProvider,
} from '../src';
import {getThemeObject} from '../src/test/theme-select-object';
import {StoryDocsHeader} from '../src/test/storybook-comps';

const unlimitedScenarios = [
'grid',
Expand All @@ -17,6 +24,7 @@ const unlimitedScenarios = [
'theme-checker',
'popover',
'audio-player-composable',
'text-area',
];

const BackgroundColor = styled.div`
Expand Down Expand Up @@ -48,9 +56,7 @@ const Background = ({children}) => (
</BackgroundColor>
);
const LimitSizeDecorator = ({children}) => <Container>{children}</Container>;
const MediaQueryProviderDecorator = ({children}) => (
<MediaQueryProvider>{children}</MediaQueryProvider>
);

const NoDecorator = ({children}) => <>{children}</>;

export const parameters = {
Expand Down Expand Up @@ -88,6 +94,18 @@ export const parameters = {
},
],
},
docs: {
// We create a custom Docs page, using of our components for the header
page: () => {
const docsContext = React.useContext(DocsContext);
return (
<ThemeProvider theme={newskitLightTheme}>
<StoryDocsHeader context={docsContext} />
<Stories includePrimary />
</ThemeProvider>
);
},
},
};

export const decorators = [
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@
"@mdx-js/loader": "^1.5.8",
"@mdx-js/react": "^1.5.8",
"@next/mdx": "^9.3.5",
"@storybook/addon-docs": "^6.5.10",
"@storybook/addon-actions": "^6.5.9",
"@storybook/addon-essentials": "^6.5.9",
"@storybook/addon-links": "^6.5.9",
Expand Down
96 changes: 80 additions & 16 deletions site/theme/__tests__/__snapshots__/doc-theme.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1363,7 +1363,11 @@ Object {
},
"invalid:focus": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
"borderColor": "{{outlines.outlineColorDefault}}",
"borderColor": "{{colors.transparent}}",
"outlineColor": "{{outlines.outlineColorDefault}}",
"outlineStyle": "{{outlines.outlineStyleDefault}}",
"outlineWidth": "{{outlines.outlineWidthDefault}}",
"safariOutlineStyle": "{{outlines.safariOutlineStyleDefault}}",
},
"invalid:hover": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
Expand All @@ -1377,7 +1381,11 @@ Object {
},
"valid:focus": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
"borderColor": "{{outlines.outlineColorDefault}}",
"borderColor": "{{colors.transparent}}",
"outlineColor": "{{outlines.outlineColorDefault}}",
"outlineStyle": "{{outlines.outlineStyleDefault}}",
"outlineWidth": "{{outlines.outlineWidthDefault}}",
"safariOutlineStyle": "{{outlines.safariOutlineStyleDefault}}",
},
"valid:hover": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
Expand Down Expand Up @@ -4004,7 +4012,11 @@ Object {
},
"invalid:focus": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
"borderColor": "{{outlines.outlineColorDefault}}",
"borderColor": "{{colors.transparent}}",
"outlineColor": "{{outlines.outlineColorDefault}}",
"outlineStyle": "{{outlines.outlineStyleDefault}}",
"outlineWidth": "{{outlines.outlineWidthDefault}}",
"safariOutlineStyle": "{{outlines.safariOutlineStyleDefault}}",
},
"invalid:hover": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
Expand All @@ -4018,7 +4030,11 @@ Object {
},
"valid:focus": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
"borderColor": "{{outlines.outlineColorDefault}}",
"borderColor": "{{colors.transparent}}",
"outlineColor": "{{outlines.outlineColorDefault}}",
"outlineStyle": "{{outlines.outlineStyleDefault}}",
"outlineWidth": "{{outlines.outlineWidthDefault}}",
"safariOutlineStyle": "{{outlines.safariOutlineStyleDefault}}",
},
"valid:hover": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
Expand Down Expand Up @@ -6648,7 +6664,11 @@ Object {
},
"invalid:focus": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
"borderColor": "{{outlines.outlineColorDefault}}",
"borderColor": "{{colors.transparent}}",
"outlineColor": "{{outlines.outlineColorDefault}}",
"outlineStyle": "{{outlines.outlineStyleDefault}}",
"outlineWidth": "{{outlines.outlineWidthDefault}}",
"safariOutlineStyle": "{{outlines.safariOutlineStyleDefault}}",
},
"invalid:hover": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
Expand All @@ -6662,7 +6682,11 @@ Object {
},
"valid:focus": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
"borderColor": "{{outlines.outlineColorDefault}}",
"borderColor": "{{colors.transparent}}",
"outlineColor": "{{outlines.outlineColorDefault}}",
"outlineStyle": "{{outlines.outlineStyleDefault}}",
"outlineWidth": "{{outlines.outlineWidthDefault}}",
"safariOutlineStyle": "{{outlines.safariOutlineStyleDefault}}",
},
"valid:hover": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
Expand Down Expand Up @@ -9289,7 +9313,11 @@ Object {
},
"invalid:focus": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
"borderColor": "{{outlines.outlineColorDefault}}",
"borderColor": "{{colors.transparent}}",
"outlineColor": "{{outlines.outlineColorDefault}}",
"outlineStyle": "{{outlines.outlineStyleDefault}}",
"outlineWidth": "{{outlines.outlineWidthDefault}}",
"safariOutlineStyle": "{{outlines.safariOutlineStyleDefault}}",
},
"invalid:hover": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
Expand All @@ -9303,7 +9331,11 @@ Object {
},
"valid:focus": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
"borderColor": "{{outlines.outlineColorDefault}}",
"borderColor": "{{colors.transparent}}",
"outlineColor": "{{outlines.outlineColorDefault}}",
"outlineStyle": "{{outlines.outlineStyleDefault}}",
"outlineWidth": "{{outlines.outlineWidthDefault}}",
"safariOutlineStyle": "{{outlines.safariOutlineStyleDefault}}",
},
"valid:hover": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
Expand Down Expand Up @@ -11933,7 +11965,11 @@ Object {
},
"invalid:focus": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
"borderColor": "{{outlines.outlineColorDefault}}",
"borderColor": "{{colors.transparent}}",
"outlineColor": "{{outlines.outlineColorDefault}}",
"outlineStyle": "{{outlines.outlineStyleDefault}}",
"outlineWidth": "{{outlines.outlineWidthDefault}}",
"safariOutlineStyle": "{{outlines.safariOutlineStyleDefault}}",
},
"invalid:hover": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
Expand All @@ -11947,7 +11983,11 @@ Object {
},
"valid:focus": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
"borderColor": "{{outlines.outlineColorDefault}}",
"borderColor": "{{colors.transparent}}",
"outlineColor": "{{outlines.outlineColorDefault}}",
"outlineStyle": "{{outlines.outlineStyleDefault}}",
"outlineWidth": "{{outlines.outlineWidthDefault}}",
"safariOutlineStyle": "{{outlines.safariOutlineStyleDefault}}",
},
"valid:hover": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
Expand Down Expand Up @@ -14574,7 +14614,11 @@ Object {
},
"invalid:focus": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
"borderColor": "{{outlines.outlineColorDefault}}",
"borderColor": "{{colors.transparent}}",
"outlineColor": "{{outlines.outlineColorDefault}}",
"outlineStyle": "{{outlines.outlineStyleDefault}}",
"outlineWidth": "{{outlines.outlineWidthDefault}}",
"safariOutlineStyle": "{{outlines.safariOutlineStyleDefault}}",
},
"invalid:hover": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
Expand All @@ -14588,7 +14632,11 @@ Object {
},
"valid:focus": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
"borderColor": "{{outlines.outlineColorDefault}}",
"borderColor": "{{colors.transparent}}",
"outlineColor": "{{outlines.outlineColorDefault}}",
"outlineStyle": "{{outlines.outlineStyleDefault}}",
"outlineWidth": "{{outlines.outlineWidthDefault}}",
"safariOutlineStyle": "{{outlines.safariOutlineStyleDefault}}",
},
"valid:hover": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
Expand Down Expand Up @@ -17218,7 +17266,11 @@ Object {
},
"invalid:focus": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
"borderColor": "{{outlines.outlineColorDefault}}",
"borderColor": "{{colors.transparent}}",
"outlineColor": "{{outlines.outlineColorDefault}}",
"outlineStyle": "{{outlines.outlineStyleDefault}}",
"outlineWidth": "{{outlines.outlineWidthDefault}}",
"safariOutlineStyle": "{{outlines.safariOutlineStyleDefault}}",
},
"invalid:hover": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
Expand All @@ -17232,7 +17284,11 @@ Object {
},
"valid:focus": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
"borderColor": "{{outlines.outlineColorDefault}}",
"borderColor": "{{colors.transparent}}",
"outlineColor": "{{outlines.outlineColorDefault}}",
"outlineStyle": "{{outlines.outlineStyleDefault}}",
"outlineWidth": "{{outlines.outlineWidthDefault}}",
"safariOutlineStyle": "{{outlines.safariOutlineStyleDefault}}",
},
"valid:hover": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
Expand Down Expand Up @@ -19859,7 +19915,11 @@ Object {
},
"invalid:focus": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
"borderColor": "{{outlines.outlineColorDefault}}",
"borderColor": "{{colors.transparent}}",
"outlineColor": "{{outlines.outlineColorDefault}}",
"outlineStyle": "{{outlines.outlineStyleDefault}}",
"outlineWidth": "{{outlines.outlineWidthDefault}}",
"safariOutlineStyle": "{{outlines.safariOutlineStyleDefault}}",
},
"invalid:hover": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
Expand All @@ -19873,7 +19933,11 @@ Object {
},
"valid:focus": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
"borderColor": "{{outlines.outlineColorDefault}}",
"borderColor": "{{colors.transparent}}",
"outlineColor": "{{outlines.outlineColorDefault}}",
"outlineStyle": "{{outlines.outlineStyleDefault}}",
"outlineWidth": "{{outlines.outlineWidthDefault}}",
"safariOutlineStyle": "{{outlines.safariOutlineStyleDefault}}",
},
"valid:hover": Object {
"backgroundColor": "{{colors.interactiveInput010}}",
Expand Down
1 change: 1 addition & 0 deletions src/__tests__/__snapshots__/index.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ Array [
"FormInputLabel",
"FormInputRadioButton",
"FormInputSelect",
"FormInputTextArea",
"FormInputTextField",
"Global",
"Grid",
Expand Down
Loading