Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PPDSC-2244): create text-area component #364

Merged
merged 16 commits into from
Sep 14, 2022

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Sep 7, 2022

PPDSC-2244

What

  1. Background - why this is needed
  2. What did you do:
    2.1. Created TextArea component
    2.2. Configured Storybook Docs plugin and created needed components for creating docs pages.
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the feature This change contains a new feature label Sep 7, 2022
@newskit-engineering
Copy link
Collaborator

@mutebg mutebg marked this pull request as ready for review September 8, 2022 11:19
@mutebg mutebg added the ready for design review Please assist in getting this reviewed label Sep 8, 2022
@mutebg mutebg added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Sep 13, 2022
@mutebg mutebg merged commit 698f49a into main Sep 14, 2022
@mutebg mutebg deleted the feat/PPDSC-2244-create-text-area branch September 14, 2022 11:49
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
* feat(PPDSC-2244): create text-area component

* feat(PPDSC-2244): add resize prop

* feat(PPDSC-2244): fix overrides

* feat(PPDSC-2244): add unit tests

* feat(PPDSC-2244): add text-area instrumantation and fix style preset

* feat(PPDSC-2244): update snapshots

* feat(PPDSC-2244): fix coverage

* feat(PPDSC-2244): configure docs in storybook

* feat(PPDSC-2244): update stories

* feat(PPDSC-2244): enhance storybook docs page

* feat(PPDSC-2244): clean up

* feat(PPDSC-2244): update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants