Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2297): NewsKit homepage update - banners, explore and more #336

Conversation

evgenitsn
Copy link
Contributor

@evgenitsn evgenitsn commented Aug 16, 2022

PPDSC-2297

What

Added new sections to the new NewsKit homepage:

  • World Design Systems Week 2022 banner
  • Explore
  • Contribute banner
  • Keep in touch
  • Supported brands

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@evgenitsn evgenitsn added docs Improvements or additions to documentation ready for design review Please assist in getting this reviewed labels Aug 16, 2022
@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Aug 18, 2022
@evgenitsn evgenitsn merged commit 2beec3a into main Aug 22, 2022
@evgenitsn evgenitsn deleted the docs/PPDSC-2297-newskit-homepage-update-banner-contribute-explore-more branch August 22, 2022 13:56
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
…#336)

* docs(PPDSC-2297): newskit homepage update - banners, explore and more

* docs(PPDSC-2297): update brand grid

* docs(PPDSC-2297): update sections and ssr mismatch fixed

* docs(PPDSC-2297): update random logos naming

* docs(PPDSC-2297): address design review comments

* docs(PPDSC-2297): update Explore Foundations illustration

* docs(PPDSC-2297): address design comments

* docs(PPDSC-2297): add full stop to a copy

* docs(PPDSC-2297): update the banners to non interactive

* docs(PPDSC-2297): update snapshots

* docs(PPDSC-2297): update useReactKeys usage

* docs(PPDSC-2297): address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants