-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(PPDSC-2297): NewsKit homepage update - banners, explore and more #336
Merged
evgenitsn
merged 22 commits into
main
from
docs/PPDSC-2297-newskit-homepage-update-banner-contribute-explore-more
Aug 22, 2022
Merged
docs(PPDSC-2297): NewsKit homepage update - banners, explore and more #336
evgenitsn
merged 22 commits into
main
from
docs/PPDSC-2297-newskit-homepage-update-banner-contribute-explore-more
Aug 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can preview these changes on: |
…er-contribute-explore-more
…er-contribute-explore-more
…er-contribute-explore-more
…er-contribute-explore-more
mutebg
suggested changes
Aug 22, 2022
8 tasks
…er-contribute-explore-more
mutebg
reviewed
Aug 22, 2022
mutebg
approved these changes
Aug 22, 2022
…er-contribute-explore-more
Vanals
approved these changes
Aug 22, 2022
Xin00163
pushed a commit
that referenced
this pull request
Oct 17, 2022
…#336) * docs(PPDSC-2297): newskit homepage update - banners, explore and more * docs(PPDSC-2297): update brand grid * docs(PPDSC-2297): update sections and ssr mismatch fixed * docs(PPDSC-2297): update random logos naming * docs(PPDSC-2297): address design review comments * docs(PPDSC-2297): update Explore Foundations illustration * docs(PPDSC-2297): address design comments * docs(PPDSC-2297): add full stop to a copy * docs(PPDSC-2297): update the banners to non interactive * docs(PPDSC-2297): update snapshots * docs(PPDSC-2297): update useReactKeys usage * docs(PPDSC-2297): address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
Improvements or additions to documentation
ready for review
Please assist in getting this reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPDSC-2297
What
Added new sections to the new NewsKit homepage:
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: