Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(PPDSC-1995): Update NewsKit theme - dark & light #345

Merged
merged 39 commits into from
Aug 25, 2022
Merged

docs(PPDSC-1995): Update NewsKit theme - dark & light #345

merged 39 commits into from
Aug 25, 2022

Conversation

evgenitsn
Copy link
Contributor

@evgenitsn evgenitsn commented Aug 22, 2022 •
edited
Loading

PPDSC-1995

What

Updated NewsKit theme tokens for dark and light theme

  • Updated colours
  • Updated a few typography presets

BREAKING CHANGE: updated theme is considered as a breaking change

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

image

image

After:

image

image

**Who should review this PR:**

How to test:

evgenitsn added 20 commits August 16, 2022 12:55
@evgenitsn
docs(PPDSC-2297): newskit homepage update - banners, explore and more
9a1cb93
@evgenitsn
docs(PPDSC-2297): update brand grid
463d674
@evgenitsn
docs(PPDSC-2297): update sections and ssr mismatch fixed
f156e9c
@evgenitsn
docs(PPDSC-2297): update random logos naming
ca448fe
@evgenitsn
docs(PPDSC-2297): addressed design review comments
27e244d
@evgenitsn
docs(PPDSC-2297): update Explore Foundations illustration
f734f8e
@evgenitsn
Merge branch 'main' into docs/PPDSC-2297-newskit-homepage-update-bann…
afebd72 
…er-contribute-explore-more
@evgenitsn
Merge branch 'main' into docs/PPDSC-2297-newskit-homepage-update-bann…
be83e40 
…er-contribute-explore-more
@evgenitsn
docs(PPDSC-2297): addressing design comments
59d1f85
@evgenitsn
docs(PPDSC-2297): addressing design comments
9b0541b
@evgenitsn
Merge branch 'main' into docs/PPDSC-2297-newskit-homepage-update-bann…
80585df 
…er-contribute-explore-more
@evgenitsn
docs(PPDSC-2297): add full stop to a copy
5f6bda9
@evgenitsn
docs(PPDSC-2297): update the banners to non interactive
9192ad4
@evgenitsn
docs(PPDSC-2297): update snapshots
b322036
@evgenitsn
feat(PPDSC-1995): update typography presets
fa902b1
@evgenitsn
feat(PPDSC-1995): update snapshots
d755c2e
@evgenitsn
Merge branch 'main' into docs/PPDSC-2297-newskit-homepage-update-bann…
de452c0 
…er-contribute-explore-more
@evgenitsn
feat(PPDSC-1995): update snapshots
6eedb53
@evgenitsn
feat(PPDSC-1995): update theme
3873ad0
@evgenitsn
feat(PPDSC-1995): remove background color on SectionNavigation
8b6c7f0
@evgenitsn evgenitsn added feature This change contains a new feature ready for design review Please assist in getting this reviewed labels Aug 22, 2022
Base automatically changed from docs/PPDSC-2297-newskit-homepage-update-banner-contribute-explore-more to main August 22, 2022 13:56
@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-1995-update-newskit-theme-dark-and-light
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-1995-update-newskit-theme-dark-and-light/storybook

evgenitsn added 14 commits August 23, 2022 09:13
@evgenitsn
Merge branch 'main' into feat/PPDSC-1995-update-newskit-theme-dark-an…
7a816c5 
…d-light
@evgenitsn
feat(PPDSC-1995): update illustrations
a2ead6f
@evgenitsn
feat(PPDSC-1995): update theme colors
66b36d9
@evgenitsn
feat(PPDSC-1995): update theme colours
8f36d82
@evgenitsn
Merge branch 'main' into feat/PPDSC-1995-update-newskit-theme-dark-an…
58bc315 
…d-light
@evgenitsn
feat(PPDSC-1995): updated snapshots
5968580
@evgenitsn
feat(PPDSC-1995): update theme values
f049ee5
@evgenitsn
feat(PPDSC-1995): update snapshots
a3e12da
@evgenitsn
Merge branch 'main' into feat/PPDSC-1995-update-newskit-theme-dark-an…
0723a04 
…d-light
@evgenitsn
feat(PPDSC-1995): update snapshots
fb29967
@evgenitsn
feat(PPDSC-1995): update dark theme tokens, align banner and toast
4dccc07
@evgenitsn
feat(PPDSC-1995): update snapshots
bc7d467
@evgenitsn
feat(PPDSC-1995): update audio player stories theme
969847e
@evgenitsn
feat(PPDSC-1995): update few dark tokens
667ea80
@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Aug 24, 2022
mutebg
mutebg previously approved these changes Aug 25, 2022
View reviewed changes
@evgenitsn evgenitsn requested a review from mutebg August 25, 2022 08:30
Srinivasan-Ramasamy
Srinivasan-Ramasamy approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@Srinivasan-Ramasamy Srinivasan-Ramasamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Nice work @evgenitsn 👍

@evgenitsn evgenitsn merged commit dd9803c into main Aug 25, 2022
@evgenitsn evgenitsn deleted the feat/PPDSC-1995-update-newskit-theme-dark-and-light branch August 25, 2022 12:23
@evgenitsn evgenitsn mentioned this pull request Aug 25, 2022
Merged
8 tasks
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
@evgenitsn
docs(PPDSC-1995): update NewsKit theme - dark & light (#345)
9abfc09 
* docs(PPDSC-2297): newskit homepage update - banners, explore and more

* docs(PPDSC-2297): update brand grid

* docs(PPDSC-2297): update sections and ssr mismatch fixed

* docs(PPDSC-2297): update random logos naming

* docs(PPDSC-2297): addressed design review comments

* docs(PPDSC-2297): update Explore Foundations illustration

* docs(PPDSC-2297): addressing design comments

* docs(PPDSC-2297): add full stop to a copy

* docs(PPDSC-2297): update the banners to non interactive

* docs(PPDSC-2297): update snapshots

* feat(PPDSC-1995): update typography presets

* feat(PPDSC-1995): update snapshots

* feat(PPDSC-1995): update theme

* feat(PPDSC-1995): remove background color on SectionNavigation

* feat(PPDSC-1995): update illustrations

* feat(PPDSC-1995): update theme colors

* feat(PPDSC-1995): update theme colours

* feat(PPDSC-1995): updated snapshots

* feat(PPDSC-1995): update theme values

* feat(PPDSC-1995): update snapshots

* feat(PPDSC-1995): update snapshots

* feat(PPDSC-1995): update dark theme tokens, align banner and toast

* feat(PPDSC-1995): update snapshots

* feat(PPDSC-1995): update audio player stories theme

* feat(PPDSC-1995): update few dark tokens

* feat(PPDSC-1995): update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Srinivasan-Ramasamy Srinivasan-Ramasamy Srinivasan-Ramasamy approved these changes

@mutebg mutebg mutebg approved these changes

@jps jps Awaiting requested review from jps

@Xin00163 Xin00163 Awaiting requested review from Xin00163

@pdimova pdimova Awaiting requested review from pdimova

@baburay23 baburay23 Awaiting requested review from baburay23

@Vanals Vanals Awaiting requested review from Vanals

Assignees
No one assigned
Labels
feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evgenitsn @newskit-engineering @mutebg @Srinivasan-Ramasamy