Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PPDSC-2256): update dropcap logical props and presets #312

Merged
merged 7 commits into from
Jul 28, 2022
Merged

feat(PPDSC-2256): update dropcap logical props and presets #312

merged 7 commits into from
Jul 28, 2022

Conversation

evgenitsn
Copy link
Contributor

PPDSC-2256

What

Updated <P dropCap/> to support logical props
Updated <P dropCap/> typography presets
Updated <P dropCap/> defaults

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

image

After:

image

Who should review this PR:

How to test:

@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed ready for design review Please assist in getting this reviewed labels Jul 25, 2022
@github-actions github-actions bot added the feature This change contains a new feature label Jul 25, 2022
@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2256-update-dropcap-logical-props-and-presets
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2256-update-dropcap-logical-props-and-presets/storybook

mstuartf
mstuartf previously approved these changes Jul 25, 2022
View reviewed changes
@evgenitsn evgenitsn removed the ready for design review Please assist in getting this reviewed label Jul 26, 2022
@evgenitsn evgenitsn requested a review from mstuartf July 27, 2022 12:23
@evgenitsn evgenitsn merged commit 5e4802e into main Jul 28, 2022
@evgenitsn evgenitsn deleted the feat/PPDSC-2256-update-dropcap-logical-props-and-presets branch July 28, 2022 12:42
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
@evgenitsn
feat(PPDSC-2256): update dropcap logical props and presets (#312)
1af06df 
* feat(PPDSC-2256): update dropcap logical props and presets

* feat(PPDSC-2256): add unit test

* feat(PPDSC-2256): design review comments

* feat(PPDSC-2256): update story name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xin00163 Xin00163 Xin00163 approved these changes

@baburay23 baburay23 baburay23 approved these changes

@jps jps Awaiting requested review from jps

@pdimova pdimova Awaiting requested review from pdimova

@mutebg mutebg Awaiting requested review from mutebg

@Vanals Vanals Awaiting requested review from Vanals

@Srinivasan-Ramasamy Srinivasan-Ramasamy Awaiting requested review from Srinivasan-Ramasamy

@mstuartf mstuartf Awaiting requested review from mstuartf

Assignees
No one assigned
Labels
feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@evgenitsn @newskit-engineering @Xin00163 @mstuartf @baburay23