feat(PPDSC-2256): design review comments

newscorp-ghfb · Jul 26, 2022 · c3d0931 · c3d0931
1 parent 92d414d
commit c3d0931
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 28 deletions.
diff --git a/src/theme/__tests__/__snapshots__/theme.test.ts.snap b/src/theme/__tests__/__snapshots__/theme.test.ts.snap
@@ -2104,8 +2104,6 @@ Object {
   },
   "paragraph": Object {
     "dropCap": Object {
-      "marginBlockStart": "space010",
-      "marginInlineEnd": "0.15em",
       "paddingBlockEnd": Object {
         "lg": "space040",
         "md": "space030",

diff --git a/src/theme/presets/typography-presets.ts b/src/theme/presets/typography-presets.ts
@@ -337,23 +337,11 @@ typographyPresets.utilityButton030 = {
 
 // Dropcap
 typographyPresets.editorialDropCap010 = {
-  fontFamily: '{{fonts.fontFamily020.fontFamily}}',
-  fontSize: '{{fonts.fontSize120}}',
-  lineHeight: '{{fonts.fontLineHeight020}}',
-  fontWeight: '{{fonts.fontWeight020}}',
-  letterSpacing: '{{fonts.fontLetterSpacing030}}',
+  ...typographyPresets.editorialDisplay010,
 };
 typographyPresets.editorialDropCap020 = {
-  fontFamily: '{{fonts.fontFamily020.fontFamily}}',
-  fontSize: '{{fonts.fontSize130}}',
-  lineHeight: '{{fonts.fontLineHeight020}}',
-  fontWeight: '{{fonts.fontWeight020}}',
-  letterSpacing: '{{fonts.fontLetterSpacing030}}',
+  ...typographyPresets.editorialDisplay020,
 };
 typographyPresets.editorialDropCap030 = {
-  fontFamily: '{{fonts.fontFamily020.fontFamily}}',
-  fontSize: '{{fonts.fontSize140}}',
-  lineHeight: '{{fonts.fontLineHeight020}}',
-  fontWeight: '{{fonts.fontWeight020}}',
-  letterSpacing: '{{fonts.fontLetterSpacing030}}',
+  ...typographyPresets.editorialDisplay030,
 };
diff --git a/src/typography/__tests__/__snapshots__/paragraph.test.tsx.snap b/src/typography/__tests__/__snapshots__/paragraph.test.tsx.snap
@@ -144,9 +144,6 @@ exports[`Paragraph renders with drop cap 1`] = `
 .emotion-1 {
   float: left;
   color: #0A0A0A;
-  -webkit-margin-end: 0.15em;
-  margin-inline-end: 0.15em;
-  margin-block-start: 4px;
 }
 
 @media screen and (max-width: 767px) {
@@ -257,9 +254,6 @@ exports[`Paragraph renders with drop cap and complex children 1`] = `
 .emotion-1 {
   float: left;
   color: #0A0A0A;
-  -webkit-margin-end: 0.15em;
-  margin-inline-end: 0.15em;
-  margin-block-start: 4px;
 }
 
 @media screen and (max-width: 767px) {
@@ -388,10 +382,7 @@ exports[`Paragraph renders with dropCap logical props 1`] = `
 .emotion-1 {
   float: left;
   color: #0A0A0A;
-  -webkit-margin-end: 0.15em;
-  margin-inline-end: 0.15em;
   margin-inline: 8px;
-  margin-block-start: 4px;
   margin-block: 8px;
   padding-inline: 8px;
   padding-block: 8px;

diff --git a/src/typography/paragraph/defaults.ts b/src/typography/paragraph/defaults.ts
@@ -19,8 +19,6 @@ export default {
         md: 'space030',
         lg: 'space040',
       },
-      marginBlockStart: 'space010',
-      marginInlineEnd: '0.15em',
     },
   },
 };