-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PPDSC-2135): add unified script to Consent #193
Merged
Merged
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
108d5eb
feat(PPDSC-2135): add unified script to Consent
tbradbury 8baf472
feat(PPDSC-2135): refactor to enable CCPA script
tbradbury bf87815
feat(PPDSC-2135): fix mdx error update tests
tbradbury 47afca0
feat(PPDSC-2135): add unified script logic to link
tbradbury 415ecbc
Merge branch 'main' into feat/PPDSC-2135-sourcepoint
tbradbury 32fabef
feat(PPDSC-2135): refactor so stub logic
tbradbury add7809
Merge branch 'main' into feat/PPDSC-2135-sourcepoint
tbradbury 63034b7
Merge branch 'main' into feat/PPDSC-2135-sourcepoint
tbradbury 7bf3f22
Merge branch 'main' into feat/PPDSC-2135-sourcepoint
tbradbury cff314b
Merge branch 'main' into feat/PPDSC-2135-sourcepoint
tbradbury 845818b
Merge branch 'main' into feat/PPDSC-2135-sourcepoint
tbradbury b6effdb
Merge branch 'main' into feat/PPDSC-2135-sourcepoint
tbradbury 8f0f989
Merge branch 'main' into feat/PPDSC-2135-sourcepoint
tbradbury 9a0232d
feat(PPDSC-2135): update tabToOpen type
tbradbury ba4355a
feat(PPDSC-2135): fix typos
tbradbury File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,13 +29,27 @@ The consent settings link supports any prop valid on the <a href='/components/li | |
Custom and required props are detailed below: | ||
|
||
<LegacyBlock marginTop="sizing040"> | ||
<Prop required name="siteId" type="string"> | ||
Your Sourcepoint site id. | ||
</Prop> | ||
<Prop name="privacyManagerId" type="string"> | ||
<Prop required name="privacyManagerId" type="string"> | ||
Your privacy manager id. | ||
</Prop> | ||
<Prop name="siteId" type="string"> | ||
Your Sourcepoint site id. This is used for the legacy TCFv1 sourcepoint script. | ||
<br/> | ||
<br/> | ||
The legacy TCFv2 script only needs privacy manager id. | ||
</Prop> | ||
<Prop name="gdpr" type="boolean"> | ||
If your using the unified sourcepoiont script for GDPR. | ||
tbradbury marked this conversation as resolved.
Show resolved
Hide resolved
|
||
</Prop> | ||
<Prop name="ccpa" type="boolean"> | ||
If your using the unified sourcepoiont script for CCPA. | ||
tbradbury marked this conversation as resolved.
Show resolved
Hide resolved
|
||
</Prop> | ||
<Prop name="tabToOpen" type="string"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should it be a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. updated |
||
If your using the unified sourcepoiont script for GDPR, you can choose the opening view of modal. | ||
</Prop> | ||
<Prop name="children" type="ReactNode" default="Manage Consent"> | ||
The content of the link. Can be undefined and left to default text. | ||
</Prop> | ||
</LegacyBlock> | ||
|
||
[See tabToOpen options](https://docs.sourcepoint.com/hc/en-us/articles/4402697202323) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
import { Consent } from 'newskit'; | ||
|
||
<body> | ||
<Consent sourcePointConfigTCFV2={{ accountId: 259 }} /> | ||
<Consent sourcePointConfigUnified={{accountId: 259, gdpr: {}}} /> | ||
</body>; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those gonna change from time to time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe so it what we do on Render and we have not had to change them once.