Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PPDSC-2135): add unified script to Consent #193

Merged
merged 15 commits into from
May 23, 2022
Merged

feat(PPDSC-2135): add unified script to Consent #193

merged 15 commits into from
May 23, 2022

Conversation

tbradbury
Copy link
Contributor

PPDSC-2135

What

  1. Sourcepoint have a new unified script, all client created after May 21 need to use this new script.
  2. Added a new unified script option in the consent component. Also updated the docs.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@tbradbury tbradbury added the feature This change contains a new feature label May 6, 2022
@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2135-sourcepoint
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2135-sourcepoint/storybook

Xin00163
Xin00163 reviewed May 9, 2022
View reviewed changes
site/pages/_document.tsx Outdated Show resolved Hide resolved
@tbradbury tbradbury added the ready for review Please assist in getting this reviewed label May 16, 2022
Xin00163
Xin00163 reviewed May 19, 2022
View reviewed changes
cypress/support/commands.js
@@ -1,5 +1,6 @@
Cypress.Commands.add('mockConsentAndVisit', url => {
cy.intercept('GET', '**/wrapper/tcfv2/v1/gdpr/**', 'fx:consent-request');
cy.setCookie('nukt_sp_consent', 'JABCDEFGHI');
cy.setCookie('consentUUID', '0714192a-0776-4b78-b462-41dde53d35e8_7');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those gonna change from time to time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe so it what we do on Render and we have not had to change them once.

site/pages/components/consent-settings-link.mdx Outdated
<Prop name="ccpa" type="boolean">
If your using the unified sourcepoiont script for CCPA.
</Prop>
<Prop name="tabToOpen" type="string">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be a string? What value should it take?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Xin00163
Xin00163 reviewed May 19, 2022
View reviewed changes
Copy link
Contributor

@Xin00163 Xin00163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be on the safe side: does this need to be verified by clients like virgin for example?

mutebg
mutebg previously approved these changes May 19, 2022
View reviewed changes
@tbradbury
Copy link
Contributor Author

Just to be on the safe side: does this need to be verified by clients like virgin for example?

Yes but Wireless can't test till at least the 30th. This does not effect the old implementation so James says we should move it forward and Wireless can test when ready

Xin00163
Xin00163 previously approved these changes May 20, 2022
View reviewed changes
@tbradbury tbradbury merged commit 6eb3d38 into main May 23, 2022
@tbradbury tbradbury deleted the feat/PPDSC-2135-sourcepoint branch May 23, 2022 14:22
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
@tbradbury
feat(PPDSC-2135): add unified script to Consent (#193)
3e6733d 
* feat(PPDSC-2135): add unified script to Consent

* feat(PPDSC-2135): refactor to enable CCPA script

* feat(PPDSC-2135): fix mdx error update tests

* feat(PPDSC-2135): add unified script logic to link

* feat(PPDSC-2135): refactor so stub logic

* feat(PPDSC-2135): update tabToOpen type

* feat(PPDSC-2135): fix typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstuartf mstuartf mstuartf left review comments

@Vanals Vanals Vanals approved these changes

@Xin00163 Xin00163 Xin00163 approved these changes

@mutebg mutebg mutebg left review comments

@jps jps Awaiting requested review from jps

@pdimova pdimova Awaiting requested review from pdimova

@baburay23 baburay23 Awaiting requested review from baburay23

@evgenitsn evgenitsn Awaiting requested review from evgenitsn

@Srinivasan-Ramasamy Srinivasan-Ramasamy Awaiting requested review from Srinivasan-Ramasamy

Assignees
No one assigned
Labels
feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tbradbury @newskit-engineering @mutebg @Xin00163 @Vanals @mstuartf